-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new section + legacy 1.1.6 #5666
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
approved these changes
Jan 26, 2021
carmocca
approved these changes
Jan 26, 2021
SeanNaren
approved these changes
Jan 26, 2021
7 tasks
PEP8 is failing for #4369 (comment) but after fixing this as a blind typo, the particular test fails... :D |
ydcjeff
approved these changes
Jan 27, 2021
Codecov Report
@@ Coverage Diff @@
## master #5666 +/- ##
======================================
Coverage 93% 93%
======================================
Files 135 135
Lines 10051 10051
======================================
Hits 9383 9383
Misses 668 668 |
tchaton
pushed a commit
that referenced
this pull request
Feb 5, 2021
Borda
added a commit
that referenced
this pull request
Feb 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci
Continuous Integration
docs
Documentation related
priority: 1
Medium priority task
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
adding new section after 1.1.6 release and add test for just release 1.1.6
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃