Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new section + legacy 1.1.6 #5666

Merged
merged 3 commits into from
Jan 27, 2021
Merged

new section + legacy 1.1.6 #5666

merged 3 commits into from
Jan 27, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Jan 26, 2021

What does this PR do?

adding new section after 1.1.6 release and add test for just release 1.1.6

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added docs Documentation related ci Continuous Integration labels Jan 26, 2021
@Borda Borda added this to the 1.1.x milestone Jan 26, 2021
@Borda Borda enabled auto-merge (squash) January 26, 2021 23:31
@Borda Borda added ready PRs ready to be merged priority: 1 Medium priority task labels Jan 26, 2021
@Borda
Copy link
Member Author

Borda commented Jan 26, 2021

PEP8 is failing for #4369 (comment) but after fixing this as a blind typo, the particular test fails... :D

@Borda Borda merged commit 861d699 into master Jan 27, 2021
@Borda Borda deleted the docs/follow-1.1.7 branch January 27, 2021 04:52
@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #5666 (1213b98) into master (c462b27) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #5666   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         135     135           
  Lines       10051   10051           
======================================
  Hits         9383    9383           
  Misses        668     668           

tchaton pushed a commit that referenced this pull request Feb 5, 2021
Borda added a commit that referenced this pull request Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration docs Documentation related priority: 1 Medium priority task ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants