Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Trainer.validate(…) method to run one validation epoch #4948

Merged
merged 45 commits into from
Mar 11, 2021
Merged
Changes from 1 commit
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
edb3e83
Refactor Trainer in advance of implementing Trainer.validate
EliaCereda Dec 2, 2020
03d7994
Merge remote-tracking branch 'upstream/master' into feature/trainer-v…
EliaCereda Dec 2, 2020
5a54485
Add Trainer.validate(...) method to perform one evaluation epoch over…
EliaCereda Dec 2, 2020
e06775c
Rename methods in Trainer and Accelerator to reflect that they are us…
EliaCereda Dec 2, 2020
b4e409c
Update docs to mention the new Trainer.validate method and associated…
EliaCereda Dec 2, 2020
96e42ba
Add tests for Trainer.validate(…)
EliaCereda Dec 2, 2020
85b3c9f
Update CHANGELOG.md
EliaCereda Dec 2, 2020
39113dc
Merge branch 'master' into feature/trainer-validate-2
tchaton Dec 3, 2020
a6be0d8
Replace usages of Trainer.testing with Trainer.evaluating, should be …
EliaCereda Dec 4, 2020
a922d57
Merge remote-tracking branch 'upstream/master' into feature/trainer-v…
EliaCereda Dec 4, 2020
595f4e8
Clean up calls to LightningDataModule.setup()
EliaCereda Dec 8, 2020
0b09248
Update test_trainer_validate_loop.py to use BoringModel instead of Ev…
EliaCereda Dec 8, 2020
d691d79
Merge remote-tracking branch 'upstream/master' into feature/trainer-v…
EliaCereda Dec 8, 2020
52eaa70
Merge branch 'feature/trainer-validate-1' into feature/trainer-valida…
EliaCereda Dec 8, 2020
06b4419
Fix ShardedPlugin when evaluating
EliaCereda Dec 8, 2020
e6a8be9
Merge remote-tracking branch 'origin/feature/trainer-validate-1' into…
EliaCereda Dec 8, 2020
389940e
Add tests for Trainer.validate with ShardedPlugin
EliaCereda Dec 8, 2020
6d0a95a
Remove superfluous calls to LoggerConnector.set_stage in validate() a…
EliaCereda Dec 10, 2020
704b121
Update more docstrings to mention Trainer.validate
EliaCereda Dec 10, 2020
f6e0759
Merge branch 'release/1.2-dev' into feature/trainer-validate-1
tchaton Jan 11, 2021
90e59c7
Merge remote-tracking branch 'upstream/release/1.2-dev' into feature/…
EliaCereda Jan 26, 2021
45d7e0a
Merge branch 'feature/trainer-validate-1' into feature/trainer-valida…
EliaCereda Jan 26, 2021
12a85b3
Pass {fit,validate,test,predict} to setup()
carmocca Mar 7, 2021
d49ccd1
Fix doctest
carmocca Mar 7, 2021
23db135
stage: Optional[str] = None
carmocca Mar 7, 2021
84f5fdb
Trailing whitespace
carmocca Mar 7, 2021
188b9fe
Update docs and CHANGELOG
carmocca Mar 7, 2021
37473f0
Mention teardown
carmocca Mar 7, 2021
0a30abf
Self-review
carmocca Mar 7, 2021
0e9d69c
Address Borda's comments
carmocca Mar 7, 2021
04343ce
Merge branch 'deleteme-carmocca' into feature/trainer-validate-2
carmocca Mar 7, 2021
9758c7b
Fixing conflicts
carmocca Mar 7, 2021
18280df
Implement Trainer.validate
carmocca Mar 7, 2021
e582d58
Refactor
carmocca Mar 7, 2021
1a5b620
Merge branch 'master' into feature/trainer-validate-2
carmocca Mar 8, 2021
5b99ec0
flake8
carmocca Mar 8, 2021
9f4dce2
Refactor
carmocca Mar 8, 2021
088d4bc
Missing import
carmocca Mar 8, 2021
58fcca4
Fix test
carmocca Mar 8, 2021
babb73d
Same threshold
carmocca Mar 8, 2021
235dc27
Address tchaton's comments
carmocca Mar 8, 2021
73dd265
Merge branch 'master' into feature/trainer-validate-2
carmocca Mar 8, 2021
e423b98
Missing import
carmocca Mar 10, 2021
cdec83b
Merge branch 'master' into feature/trainer-validate-2
carmocca Mar 10, 2021
8fab50f
Apply suggestions from code review
carmocca Mar 10, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update CHANGELOG.md
  • Loading branch information
EliaCereda committed Dec 2, 2020
commit 85b3c9fe2593d848adc0358c08af8ecfd404c426
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,10 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
- Added `Pytorch Geometric` integration example with Lightning ([#4568](https://github.com/PyTorchLightning/pytorch-lightning/pull/4568))


- Added `Trainer.validate()` method to perform one evaluation epoch over the validation set (
[#4707](https://github.com/PyTorchLightning/pytorch-lightning/pull/4707))


### Changed

- Tuner algorithms will be skipped if `fast_dev_run=True` ([#3903](https://github.com/PyTorchLightning/pytorch-lightning/pull/3903))
Expand Down