Clean up #2467
Merged
Clean up #2467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2467 +/- ##
======================================
- Coverage 89% 89% -0%
======================================
Files 69 69
Lines 5518 5533 +15
======================================
+ Hits 4889 4898 +9
- Misses 629 635 +6 |
|
@zcain117 any ideas here? (https://github.com/PyTorchLightning/pytorch-lightning/pull/2467/checks?check_run_id=832554097#step:10:236) I'm just getting familiar with xla details, but is the problem that we are comparing an xla tensor vs a non-xla tensor? |
bgedik
reviewed
Jul 8, 2020
| if trainer.use_ddp or trainer.use_ddp2: | ||
| stop = torch.tensor(int(trainer.should_stop), device=pl_module.device) | ||
| dist.all_reduce(stop, op=dist.reduce_op.SUM) | ||
| dist.barrier() |
There was a problem hiding this comment.
@williamFalcon Is a barrier needed after an all reduce?
| self.stopped_epoch = trainer.current_epoch | ||
| trainer.should_stop = True | ||
|
|
||
| # stop every ddp process if any world process decides to stop | ||
| self._stop_distributed_training(trainer, pl_module) |
There was a problem hiding this comment.
The function name is misleading. This does not stop training, it just updates the trainer.should_stop state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1838
We have TPU tests now!