New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP Delay data fetcher setup #19725

Closed

awaelchli wants to merge 2 commits into master from refactor/data-iter-setup

Contributor

awaelchli commented Apr 2, 2024 •

edited

Loading

What does this PR do?

Originally introduced in #18441, new logic required us to set up the iterator earlier in the training loop to have limits correctly set and validated.

📚 Documentation preview 📚: https://pytorch-lightning--19725.org.readthedocs.build/en/19725/


          refactor

f9db815

awaelchli requested review from williamFalcon, carmocca and justusschock as code owners

April 2, 2024 17:24

github-actions bot added the pl label

Contributor

github-actions bot commented Apr 2, 2024 •

edited

Loading

⛈️ Required checks status: Has failure 🔴

Warning
This job will need to be re-run to merge your PR. If you do not have write access to the repository, you can ask Lightning-AI/lai-frameworks to re-run it. If you push a new commit, all of CI will re-trigger.

Groups summary

🔴 pytorch_lightning: Tests workflow

Check ID	Status
pl-cpu (macOS-11, lightning, 3.8, 1.13, oldest)	failure	❌
pl-cpu (macOS-11, lightning, 3.10, 1.13)	failure	❌
pl-cpu (macOS-11, lightning, 3.10, 2.1)	failure	❌
pl-cpu (macOS-11, lightning, 3.10, 2.2)	failure	❌
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.13, oldest)	failure	❌
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.13)	failure	❌
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.1)	failure	❌
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.2)	failure	❌
pl-cpu (windows-2022, lightning, 3.8, 1.13, oldest)	failure	❌
pl-cpu (windows-2022, lightning, 3.10, 1.13)	failure	❌
pl-cpu (windows-2022, lightning, 3.10, 2.1)	failure	❌
pl-cpu (windows-2022, lightning, 3.10, 2.2)	failure	❌
pl-cpu (macOS-11, pytorch, 3.8, 1.13)	failure	❌
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.13)	failure	❌
pl-cpu (windows-2022, pytorch, 3.8, 1.13)	failure	❌
pl-cpu (macOS-12, pytorch, 3.11, 2.0)	failure	❌
pl-cpu (macOS-12, pytorch, 3.11, 2.1)	failure	❌
pl-cpu (ubuntu-22.04, pytorch, 3.11, 2.0)	failure	❌
pl-cpu (ubuntu-22.04, pytorch, 3.11, 2.1)	failure	❌
pl-cpu (windows-2022, pytorch, 3.11, 2.0)	failure	❌
pl-cpu (windows-2022, pytorch, 3.11, 2.1)	failure	❌

These checks are required after the changes to src/lightning/pytorch/loops/fit_loop.py.

🔴 pytorch_lightning: Azure GPU

Check ID	Status
pytorch-lightning (GPUs) (testing Lightning \| latest)	failure	❌
pytorch-lightning (GPUs) (testing PyTorch \| latest)	failure	❌

These checks are required after the changes to src/lightning/pytorch/loops/fit_loop.py.

🟢 pytorch_lightning: Benchmarks

Check ID	Status
lightning.Benchmarks	success	✅

These checks are required after the changes to src/lightning/pytorch/loops/fit_loop.py.

🔴 pytorch_lightning: Docs

Check ID	Status
docs-make (pytorch, doctest)	failure	❌
docs-make (pytorch, html)	failure	❌

These checks are required after the changes to src/lightning/pytorch/loops/fit_loop.py.

🔴 mypy

Check ID	Status
mypy	failure	❌

These checks are required after the changes to src/lightning/pytorch/loops/fit_loop.py.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.8)	success	✅
install-pkg (ubuntu-22.04, app, 3.11)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.8)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.11)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.8)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.11)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.8)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.11)	success	✅
install-pkg (ubuntu-22.04, notset, 3.8)	success	✅
install-pkg (ubuntu-22.04, notset, 3.11)	success	✅
install-pkg (macOS-12, app, 3.8)	success	✅
install-pkg (macOS-12, app, 3.11)	success	✅
install-pkg (macOS-12, fabric, 3.8)	success	✅
install-pkg (macOS-12, fabric, 3.11)	success	✅
install-pkg (macOS-12, pytorch, 3.8)	success	✅
install-pkg (macOS-12, pytorch, 3.11)	success	✅
install-pkg (macOS-12, lightning, 3.8)	success	✅
install-pkg (macOS-12, lightning, 3.11)	success	✅
install-pkg (macOS-12, notset, 3.8)	success	✅
install-pkg (macOS-12, notset, 3.11)	success	✅
install-pkg (windows-2022, app, 3.8)	success	✅
install-pkg (windows-2022, app, 3.11)	success	✅
install-pkg (windows-2022, fabric, 3.8)	success	✅
install-pkg (windows-2022, fabric, 3.11)	success	✅
install-pkg (windows-2022, pytorch, 3.8)	success	✅
install-pkg (windows-2022, pytorch, 3.11)	success	✅
install-pkg (windows-2022, lightning, 3.8)	success	✅
install-pkg (windows-2022, lightning, 3.11)	success	✅
install-pkg (windows-2022, notset, 3.8)	success	✅
install-pkg (windows-2022, notset, 3.11)	success	✅

These checks are required after the changes to src/lightning/pytorch/loops/fit_loop.py.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

fix

2c0f8e3

awaelchli closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pl