-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StreamingDataset: Fault Tolerance v2 2/n #19201
Conversation
…-AI/lightning into add_fault_tolerance_v2
⚡ Required checks status: All passing 🟢Groups summary🟢 lightning_data: CPU workflow
These checks are required after the changes to 🟢 mypy
These checks are required after the changes to 🟢 installThese checks are required after the changes to Thank you for your contribution! 💜
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just a clarifying question
Co-authored-by: thomas <[email protected]>
Co-authored-by: thomas <[email protected]>
What does this PR do?
This PR refactors the logic to perform fault tolerance. We are now tracking the number of samples yielded from the dataloader and restoring the chunk index and the in chunk index based on the number of yielded samples.
Fixes #<issue_number>
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
cc @Borda