Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StreamingDataset: Fault Tolerance v2 2/n #19201

Merged
merged 21 commits into from
Dec 24, 2023
Merged

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Dec 21, 2023

What does this PR do?

This PR refactors the logic to perform fault tolerance. We are now tracking the number of samples yielded from the dataloader and restoring the chunk index and the in chunk index based on the number of yielded samples.

Fixes #<issue_number>

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda

@github-actions github-actions bot added the data (external) litdata package label Dec 21, 2023
@tchaton tchaton marked this pull request as ready for review December 21, 2023 17:04
Copy link
Contributor

github-actions bot commented Dec 21, 2023

⚡ Required checks status: All passing 🟢

Groups summary

🟢 lightning_data: CPU workflow
Check ID Status
data-cpu (macOS-11, lightning, 3.10, 2.1) success
data-cpu (ubuntu-20.04, lightning, 3.10, 2.1) success
data-cpu (windows-2022, lightning, 3.10, 2.1) success

These checks are required after the changes to src/lightning/data/streaming/dataloader.py, src/lightning/data/streaming/dataset.py, src/lightning/data/streaming/reader.py, src/lightning/data/streaming/shuffle.py, tests/tests_data/streaming/test_dataset.py.

🟢 mypy
Check ID Status
mypy success

These checks are required after the changes to src/lightning/data/streaming/dataloader.py, src/lightning/data/streaming/dataset.py, src/lightning/data/streaming/reader.py, src/lightning/data/streaming/shuffle.py.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.8) success
install-pkg (ubuntu-22.04, app, 3.11) success
install-pkg (ubuntu-22.04, fabric, 3.8) success
install-pkg (ubuntu-22.04, fabric, 3.11) success
install-pkg (ubuntu-22.04, pytorch, 3.8) success
install-pkg (ubuntu-22.04, pytorch, 3.11) success
install-pkg (ubuntu-22.04, lightning, 3.8) success
install-pkg (ubuntu-22.04, lightning, 3.11) success
install-pkg (ubuntu-22.04, notset, 3.8) success
install-pkg (ubuntu-22.04, notset, 3.11) success
install-pkg (macOS-12, app, 3.8) success
install-pkg (macOS-12, app, 3.11) success
install-pkg (macOS-12, fabric, 3.8) success
install-pkg (macOS-12, fabric, 3.11) success
install-pkg (macOS-12, pytorch, 3.8) success
install-pkg (macOS-12, pytorch, 3.11) success
install-pkg (macOS-12, lightning, 3.8) success
install-pkg (macOS-12, lightning, 3.11) success
install-pkg (macOS-12, notset, 3.8) success
install-pkg (macOS-12, notset, 3.11) success
install-pkg (windows-2022, app, 3.8) success
install-pkg (windows-2022, app, 3.11) success
install-pkg (windows-2022, fabric, 3.8) success
install-pkg (windows-2022, fabric, 3.11) success
install-pkg (windows-2022, pytorch, 3.8) success
install-pkg (windows-2022, pytorch, 3.11) success
install-pkg (windows-2022, lightning, 3.8) success
install-pkg (windows-2022, lightning, 3.11) success
install-pkg (windows-2022, notset, 3.8) success
install-pkg (windows-2022, notset, 3.11) success

These checks are required after the changes to src/lightning/data/streaming/dataloader.py, src/lightning/data/streaming/dataset.py, src/lightning/data/streaming/reader.py, src/lightning/data/streaming/shuffle.py.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

src/lightning/data/streaming/dataloader.py Show resolved Hide resolved
src/lightning/data/streaming/dataset.py Outdated Show resolved Hide resolved
src/lightning/data/streaming/dataset.py Outdated Show resolved Hide resolved
src/lightning/data/streaming/dataset.py Outdated Show resolved Hide resolved
@tchaton tchaton requested a review from awaelchli December 22, 2023 11:51
@tchaton tchaton requested a review from lantiga December 22, 2023 14:51
Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just a clarifying question

@mergify mergify bot added the ready PRs ready to be merged label Dec 23, 2023
@tchaton tchaton merged commit 91ef190 into master Dec 24, 2023
53 checks passed
@tchaton tchaton deleted the add_fault_tolerance_v2_2-n branch December 24, 2023 00:44
awaelchli pushed a commit that referenced this pull request Jan 30, 2024
lexierule pushed a commit that referenced this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data (external) litdata package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants