Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reduce type in FSDP mixed precision #18818

Closed
wants to merge 10 commits into from

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Oct 18, 2023

What does this PR do?

Fixes #18802
Revises #17670


📚 Documentation preview 📚: https://pytorch-lightning--18818.org.readthedocs.build/en/18818/

@github-actions github-actions bot added the fabric lightning.fabric.Fabric label Oct 18, 2023
@awaelchli awaelchli added this to the 2.1.x milestone Oct 18, 2023
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Oct 18, 2023
Copy link

gitguardian bot commented Jan 16, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Generic High Entropy Secret 78fa3af tests/tests_app/utilities/test_login.py View secret
- Base64 Basic Authentication 78fa3af tests/tests_app/utilities/test_login.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@awaelchli awaelchli modified the milestones: 2.1.x, 2.2.x Feb 8, 2024
@awaelchli awaelchli closed this Feb 11, 2024
@Borda Borda deleted the bugfix/reduce-type-mixed-precision branch July 26, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FSDP not working well with BatchNorm and 16-mixed precision
1 participant