-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close validation progress bar before updating training bar #18503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
requested review from
williamFalcon,
carmocca and
justusschock
as code owners
September 7, 2023 23:00
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #18503 +/- ##
==========================================
- Coverage 84% 50% -34%
==========================================
Files 427 419 -8
Lines 33364 33218 -146
==========================================
- Hits 28113 16683 -11430
- Misses 5251 16535 +11284 |
Borda
approved these changes
Sep 8, 2023
carmocca
approved these changes
Sep 8, 2023
Borda
pushed a commit
that referenced
this pull request
Sep 12, 2023
(cherry picked from commit a3f6e98)
lantiga
pushed a commit
that referenced
this pull request
Sep 14, 2023
(cherry picked from commit a3f6e98)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
pl
Generic label for PyTorch Lightning package
progress bar: tqdm
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fixes a minor visual glitch with the TQDM progress bar observed in the PyCharm terminal.
Before:
(The validation bar is left incomplete before switching to training)
Now:
(The validation bar is complete)
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
cc @Borda @awaelchli