Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh _FabricOptimizer.__dict__ when loading a state dict #18488

Merged
merged 6 commits into from
Sep 6, 2023
Merged

Refresh _FabricOptimizer.__dict__ when loading a state dict #18488

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
94cf021
refresh dict
awaelchli Sep 5, 2023
ff71e83
add test
awaelchli Sep 5, 2023
951114f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 5, 2023
914fc32
changelog
awaelchli Sep 5, 2023
8d22bb1
Merge remote-tracking branch 'origin/bugfix/fabric-optimizer-load-sta…
awaelchli Sep 5, 2023
9731a4b
update test
awaelchli Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/lightning/fabric/wrappers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,13 @@ def _refresh(self) -> None:
"""
# `__del__` is skipped in case the optimizer has implemented custom destructor logic which we would
# not want to call on destruction of the `_FabricOptimizer
self.__dict__.update({
k: v for k, v in self.optimizer.__dict__.items() if k not in ("load_state_dict", "state_dict", "step", "__del__")
})
self.__dict__.update(
{
k: v
for k, v in self.optimizer.__dict__.items()
if k not in ("load_state_dict", "state_dict", "step", "__del__")
}
)


class _FabricModule(_DeviceDtypeModuleMixin):
Expand Down