Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs/source-pytorch/common/lightning_module.rst #18451

Merged
merged 18 commits into from
Sep 8, 2023
Merged

Update docs/source-pytorch/common/lightning_module.rst #18451

merged 18 commits into from
Sep 8, 2023

Conversation

jxtngx
Copy link
Contributor

@jxtngx jxtngx commented Sep 1, 2023

What does this PR do?

Updates examples per #18327

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--18451.org.readthedocs.build/en/18451/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 1, 2023
@jxtngx
Copy link
Contributor Author

jxtngx commented Sep 1, 2023

updated page on rtfd staging: LightningModule

@awaelchli awaelchli added the docs Documentation related label Sep 4, 2023
@awaelchli awaelchli added this to the 2.1 milestone Sep 4, 2023
docs/source-pytorch/common/lightning_module.rst Outdated Show resolved Hide resolved
docs/source-pytorch/common/lightning_module.rst Outdated Show resolved Hide resolved
docs/source-pytorch/common/lightning_module.rst Outdated Show resolved Hide resolved
docs/source-pytorch/common/lightning_module.rst Outdated Show resolved Hide resolved
docs/source-pytorch/common/lightning_module.rst Outdated Show resolved Hide resolved
@jxtngx jxtngx requested review from awaelchli and Borda September 5, 2023 18:24
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
@mergify mergify bot added the ready PRs ready to be merged label Sep 6, 2023
@awaelchli awaelchli merged commit a013386 into Lightning-AI:master Sep 8, 2023
Borda pushed a commit that referenced this pull request Sep 12, 2023
Co-authored-by: Jirka Borovec <[email protected]>

(cherry picked from commit a013386)
lantiga pushed a commit that referenced this pull request Sep 14, 2023
Co-authored-by: Jirka Borovec <[email protected]>

(cherry picked from commit a013386)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants