Remove _handle_is_headless calls in app run loop
#18362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st_lightningapp_instance API calls for a feature which is no longer used
rlizzo
requested review from
tchaton,
lantiga,
awaelchli and
ethanwharris
as code owners
github-actions
bot
added
the
app (removed)
ethanwharris
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
LGTM, you will probably also need to remove test_handle_is_headless: https://github.com/Lightning-AI/lightning/blob/35fe3f3159c3429bb7226b2ac61cfead12b93362/tests/tests_app/utilities/test_app_helpers.py#L218
Borda
changed the title
_handle_is_headless calls in app run loop
Borda
approved these changes
Aug 21, 2023
justusschock
approved these changes
Aug 21, 2023
awaelchli
approved these changes
Aug 21, 2023
Borda
pushed a commit
that referenced
this pull request
Aug 28, 2023
* remove update_is_headless check as it is spamming the backend with list_lightningapp_instance API calls for a feature which is no longer used * removed test which is no longer needed (cherry picked from commit 0825c82)
lantiga
pushed a commit
that referenced
this pull request
Aug 30, 2023
* remove update_is_headless check as it is spamming the backend with list_lightningapp_instance API calls for a feature which is no longer used * removed test which is no longer needed (cherry picked from commit 0825c82)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
remove
LightingApp.update_is_headlessmethod as it is spamming the backend withlist_lightningapp_instancesAPI calls for a feature which is no longer usedAs per @ethanwharris, no. this should not break any currently used functionality.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
cc @Borda