Code

Explicitly enable grad in closure#18268

Code

Merged

awaelchli merged 11 commits intoLightning-AI:masterLightning-AI/pytorch-lightning:masterfrom 0x404:bugfix/no-grad0x404/lightning:bugfix/no-gradCopy head branch name to clipboardAug 10, 2023

+32

Commits

Commits on Aug 9, 2023

• test: add a test case for testing closure with no_grad optimizer

  0x404

  committed
  9fac094

  Copy full SHA for 9fac094

Commits on Aug 10, 2023

• fix: enable grad when running closure

  0x404

  committed
  80281f5

  Copy full SHA for 80281f5

• Merge branch 'master' into bugfix/no-grad

  0x404

  authored
  77bb6b0

  Copy full SHA for 77bb6b0

• fix: simply test case

  0x404

  committed
  9e9aa9f

  Copy full SHA for 9e9aa9f

• test: assert torch.is_grad_enabled during training step

  0x404

  committed
  43b422a

  Copy full SHA for 43b422a

• Merge branch 'bugfix/no-grad' of https://github.com/0x404/lightning into bugfix/no-grad

  0x404

  committed
  b1cce73

  Copy full SHA for b1cce73

• extend the test to reproduce the error on master

  awaelchli

  committed
  2821829

  Copy full SHA for 2821829

• more concise test description

  awaelchli

  committed
  deb1d2d

  Copy full SHA for deb1d2d

• [pre-commit.ci] auto fixes from pre-commit.com hooks

  Show description for 715c374
  pre-commit-ci[bot]

  committed
  715c374

  Copy full SHA for 715c374

• add changelog

  awaelchli

  committed
  76b2ca5

  Copy full SHA for 76b2ca5

• Merge branch 'bugfix/no-grad' of github.com:0x403/lightning into bugfix/no-grad

  awaelchli

  committed
  2c8a2c2

  Copy full SHA for 2c8a2c2