-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ModelCheckpoint misformats filename #17610
Merged
awaelchli
merged 4 commits into
Lightning-AI:master
from
bkiat1123:fix_format_checkpoint_name
May 12, 2023
Merged
Fix ModelCheckpoint misformats filename #17610
awaelchli
merged 4 commits into
Lightning-AI:master
from
bkiat1123:fix_format_checkpoint_name
May 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So when key a is a substring of key b, key b will be replaced first.
re.findall will always return a list, which will always have length >= 0. If groups is empty list, the for loop simply will be skipped.
Borda
approved these changes
May 11, 2023
awaelchli
approved these changes
May 12, 2023
Borda
pushed a commit
that referenced
this pull request
Jun 2, 2023
Co-authored-by: awaelchli <[email protected]> (cherry picked from commit cbc536a)
Borda
pushed a commit
that referenced
this pull request
Jun 2, 2023
Co-authored-by: awaelchli <[email protected]> (cherry picked from commit cbc536a)
lantiga
pushed a commit
that referenced
this pull request
Jun 2, 2023
Co-authored-by: awaelchli <[email protected]> (cherry picked from commit cbc536a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
callback: model checkpoint
community
This PR is from the community
pl
Generic label for PyTorch Lightning package
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As reported in this issue, filename format failed when one metric key is substring of another.
In the first iteration of the for loop, both
epoch
andepoch_test
will be formatted, which cause the error. Solve by reverse sorting the keys by length.Fixes #16290
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist