Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix property raised instead of returned #17595

Merged
merged 1 commit into from
May 8, 2023
Merged

Fix property raised instead of returned #17595

merged 1 commit into from
May 8, 2023

Conversation

bkiat1123
Copy link
Contributor

@bkiat1123 bkiat1123 commented May 8, 2023 •
edited by carmocca
Loading

What does this PR do?

Fixes #17580

No

  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label May 8, 2023
@carmocca carmocca added the bug Something isn't working label May 8, 2023
@awaelchli awaelchli added the community This PR is from the community label May 8, 2023
@awaelchli awaelchli added this to the 2.0.x milestone May 8, 2023
@mergify mergify bot added the ready PRs ready to be merged label May 8, 2023
@awaelchli awaelchli changed the title fix property raised instead of returned. Fix property raised instead of returned May 8, 2023
@awaelchli awaelchli enabled auto-merge (squash) May 8, 2023 18:47
@awaelchli awaelchli merged commit d7b668e into Lightning-AI:master May 8, 2023
@bkiat1123 bkiat1123 deleted the fix_raise_method branch May 9, 2023 06:59
Borda pushed a commit that referenced this pull request Jun 1, 2023
@bkiat1123 @Borda
Fix property raised instead of returned (#17595)
c81a6fe 
(cherry picked from commit d7b668e)
Borda pushed a commit that referenced this pull request Jun 1, 2023
@bkiat1123 @Borda
Fix property raised instead of returned (#17595)
ec9a7e5 
(cherry picked from commit d7b668e)
lantiga pushed a commit that referenced this pull request Jun 2, 2023
@bkiat1123 @lantiga
Fix property raised instead of returned (#17595)
9c39871 
(cherry picked from commit d7b668e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmocca carmocca carmocca approved these changes

@awaelchli awaelchli awaelchli approved these changes

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

Assignees
No one assigned
Labels
app (removed) Generic label for Lightning App package bug Something isn't working community This PR is from the community ready PRs ready to be merged
Projects
None yet
Milestone
2.0.x
Development

Successfully merging this pull request may close these issues.

_FastApiMockRequest class method property is raised instead of returned
3 participants
@bkiat1123 @awaelchli @carmocca