Avoid flattening hyperparameters in WandbLogger #17574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
added
feature
awaelchli
added
the
fun
for more information, see https://pre-commit.ci
…ix/wandb-sanitize
awaelchli
requested review from
carmocca,
justusschock and
williamFalcon
as code owners
Borda
approved these changes
May 5, 2023
justusschock
approved these changes
May 5, 2023
Borda
pushed a commit
that referenced
this pull request
Jun 1, 2023
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 6c8c02d)
Borda
pushed a commit
that referenced
this pull request
Jun 1, 2023
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 6c8c02d)
lantiga
pushed a commit
that referenced
this pull request
Jun 2, 2023
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 6c8c02d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #14988
Fixes #13899
A long-awaited change, but nobody was brave enough to open a PR with the simple change?? 😞 I will step up! 💪
Wandb supports displaying nested configurations for a while now! There is no need to flatten our hyperparameters anymore for logging!
I didn't expose this as an argument as proposed in #14988, because I see this as an overall improvement of the user experience, therefore I assume nobody wants the current behavior by choice. But if someone sees a reason to being able to revert back to the old behavior, let me know, and we can add it as a flag.
cc @Borda @awaelchli @morganmcg1 @borisdayma @scottire @parambharat