Fix conda badge in README #17345
Merged
Fix conda badge in README #17345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following on from #17289 it would appear that the official conda-forge package is https://anaconda.org/conda-forge/lightning However, the conda badge in the [README](https://github.com/Lightning-AI/lightning/edit/master/README.md) points to https://anaconda.org/conda-forge/pytorch-lightning Assuming I've understood correctly that [`lightning`](https://anaconda.org/conda-forge/lightning) is the official conda-forge package, would it also be worth adding a deprecation warning to [`pytorch-lightning`](https://anaconda.org/conda-forge/pytorch-lightning) (and/or redirect to [`lightning`](https://anaconda.org/conda-forge/lightning))? Thanks for any help! :)
Borda
approved these changes
Apr 14, 2023
Borda
approved these changes
Apr 24, 2023
lantiga
approved these changes
Apr 27, 2023
Borda
pushed a commit
that referenced
this pull request
May 9, 2023
(cherry picked from commit 8c18439)
Borda
pushed a commit
that referenced
this pull request
Jun 1, 2023
(cherry picked from commit 8c18439)
lantiga
pushed a commit
that referenced
this pull request
Jun 2, 2023
(cherry picked from commit 8c18439)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #17289 it would appear that the official conda-forge package is https://anaconda.org/conda-forge/lightning
However, the conda badge in the README points to https://anaconda.org/conda-forge/pytorch-lightning
Assuming I've understood correctly that
lightningis the official conda-forge package, would it also be worth adding a deprecation warning topytorch-lightning(and/or redirect tolightning)?Thanks! :)