Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightning: make type hints public #17100

Merged
merged 21 commits into from
Apr 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -53,17 +53,17 @@ wheels/
.installed.cfg
*.egg
src/*/version.info
src/lightning_app/
src/lightning_fabric/
src/pytorch_lightning/
src/lightning_app/*
src/lightning_fabric/*
src/pytorch_lightning/*
carmocca marked this conversation as resolved.
Show resolved Hide resolved
!src/*/__about__.py
!src/*/__main__.py
!src/*/__setup__.py
!src/*/__version__.py
!src/*/MANIFEST.in
!src/*/py.typed
!src/*/README.md
!src/*/*.info
!src/*/shell-folder_code-lives-lightning.info
awaelchli marked this conversation as resolved.
Show resolved Hide resolved

# PyInstaller
# Usually these files are written by a python script from a template
Expand Down
6 changes: 5 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,11 @@ def _set_manifest_path(manifest_dir: str, aggregate: bool = False, mapping: Mapp
if aggregate:
# aggregate all MANIFEST.in contents into a single temporary file
manifest_path = _named_temporary_file(manifest_dir)
lines = ["include src/lightning/version.info\n", "include requirements/base.txt\n"]
lines = [
"include src/lightning/version.info\n",
"include src/lightning/py.typed\n",
"include requirements/base.txt\n",
]
# load manifest and aggregated all manifests
for pkg in mapping.values():
pkg_manifest = os.path.join(_PATH_SRC, pkg, "MANIFEST.in")
Expand Down
Empty file added src/lightning/py.typed
Empty file.
1 change: 1 addition & 0 deletions src/lightning_app/MANIFEST.in
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,4 @@ recursive-include src/lightning_app/cli/*-template *
# TODO: remove this once lightning-ui package is ready as a dependency
recursive-include src/lightning_app/ui *
include src/lightning_app/components/serve/catimage.png
include src/lightning_app/py.typed # marker file for PEP 561
Empty file added src/lightning_app/py.typed
Empty file.
1 change: 1 addition & 0 deletions src/lightning_fabric/MANIFEST.in
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@ include src/lightning_fabric/CHANGELOG.md
include src/lightning_fabric/README.md
recursive-include requirements/fabric *.txt
include .actions/assistant.py
include src/lightning_fabric/py.typed # marker file for PEP 561
Empty file added src/lightning_fabric/py.typed
Empty file.