Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename integrations_app for accommodating flagships #16345

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

Borda
Copy link
Member

@Borda Borda commented Jan 12, 2023

What does this PR do?

preparation for #16304

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @justusschock @awaelchli @Borda

@github-actions
Copy link
Contributor

github-actions bot commented Jan 12, 2023

⛈️ Required checks status: Has failure 🔴

Warning
This job will need to be re-run to merge your PR. If you do not have write access to the repository, you can ask Lightning-AI/lai-frameworks to re-run it. If you push a new commit, all of CI will re-trigger.

Groups summary

🟢 lightning_app: Examples
Check ID Status
app-examples (macOS-11, app, 3.9, latest) success
app-examples (macOS-11, app, 3.9, oldest) success
app-examples (macOS-11, lightning, 3.9, latest) success
app-examples (ubuntu-20.04, app, 3.9, latest) success
app-examples (ubuntu-20.04, app, 3.9, oldest) success
app-examples (ubuntu-20.04, lightning, 3.9, latest) success
app-examples (windows-2022, app, 3.9, latest) success
app-examples (windows-2022, app, 3.9, oldest) success
app-examples (windows-2022, lightning, 3.9, latest) success

These checks are required after the changes to .github/workflows/ci-examples-app.yml, tests/integrations_app/__init__.py, tests/integrations_app/apps/collect_failures/__init__.py, tests/integrations_app/apps/collect_failures/app.py, tests/integrations_app/apps/collect_failures/requirements.txt, tests/integrations_app/apps/core_features_app/__init__.py, tests/integrations_app/apps/core_features_app/app.py, tests/integrations_app/apps/custom_work_dependencies/__init__.py, tests/integrations_app/apps/custom_work_dependencies/app.py, tests/integrations_app/apps/idle_timeout/__init__.py, tests/integrations_app/apps/idle_timeout/app.py, tests/integrations_app/conftest.py, tests/integrations_app/local/__init__.py, tests/integrations_app/local/test_collect_failures.py, tests/integrations_app/local/test_core_features_app.py, tests/integrations_app/local/test_custom_work_dependencies.py, tests/integrations_app/local/test_idle_timeout.py, tests/integrations_app/public/__init__.py, tests/integrations_app/public/test_app_dag.py, tests/integrations_app/public/test_argparse.py, tests/integrations_app/public/test_boring_app.py, tests/integrations_app/public/test_commands_and_api.py, tests/integrations_app/public/test_drive.py, tests/integrations_app/public/test_gradio.py, tests/integrations_app/public/test_installation_commands_app.py, tests/integrations_app/public/test_layout.py, tests/integrations_app/public/test_multi_node.py, tests/integrations_app/public/test_payload.py, tests/integrations_app/public/test_pickle_or_not.py, tests/integrations_app/public/test_quick_start.py, tests/integrations_app/public/test_scripts.py, tests/integrations_app/public/test_template_react_ui.py, tests/integrations_app/public/test_template_streamlit_ui.py, tests/integrations_app/public/test_v0_app.py.

🔴 lightning_app: Azure
Check ID Status
App.cloud-e2e failure

These checks are required after the changes to .azure/app-cloud-e2e.yml, tests/integrations_app/__init__.py, tests/integrations_app/apps/collect_failures/__init__.py, tests/integrations_app/apps/collect_failures/app.py, tests/integrations_app/apps/collect_failures/requirements.txt, tests/integrations_app/apps/core_features_app/__init__.py, tests/integrations_app/apps/core_features_app/app.py, tests/integrations_app/apps/custom_work_dependencies/__init__.py, tests/integrations_app/apps/custom_work_dependencies/app.py, tests/integrations_app/apps/idle_timeout/__init__.py, tests/integrations_app/apps/idle_timeout/app.py, tests/integrations_app/conftest.py, tests/integrations_app/local/__init__.py, tests/integrations_app/local/test_collect_failures.py, tests/integrations_app/local/test_core_features_app.py, tests/integrations_app/local/test_custom_work_dependencies.py, tests/integrations_app/local/test_idle_timeout.py, tests/integrations_app/public/__init__.py, tests/integrations_app/public/test_app_dag.py, tests/integrations_app/public/test_argparse.py, tests/integrations_app/public/test_boring_app.py, tests/integrations_app/public/test_commands_and_api.py, tests/integrations_app/public/test_drive.py, tests/integrations_app/public/test_gradio.py, tests/integrations_app/public/test_installation_commands_app.py, tests/integrations_app/public/test_layout.py, tests/integrations_app/public/test_multi_node.py, tests/integrations_app/public/test_payload.py, tests/integrations_app/public/test_pickle_or_not.py, tests/integrations_app/public/test_quick_start.py, tests/integrations_app/public/test_scripts.py, tests/integrations_app/public/test_template_react_ui.py, tests/integrations_app/public/test_template_streamlit_ui.py, tests/integrations_app/public/test_v0_app.py.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@Borda Borda enabled auto-merge (squash) January 12, 2023 14:54
@mergify mergify bot added the ready PRs ready to be merged label Jan 12, 2023
@lexierule lexierule disabled auto-merge January 12, 2023 15:13
@lexierule lexierule merged commit c2c363d into master Jan 12, 2023
@lexierule lexierule deleted the ci/flagship-rename branch January 12, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants