Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkgroup config fixes #15787

Merged
merged 4 commits into from
Nov 26, 2022
Merged

Checkgroup config fixes #15787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d7f0b68
Checkgroup config fixes
carmocca Nov 23, 2022
dd29970
Merge branch 'master' into ci/checkgroup-config-fixes
carmocca Nov 25, 2022
e730df8
Tighter timeout
carmocca Nov 25, 2022
e38154f
Merge branch 'master' into ci/checkgroup-config-fixes
carmocca Nov 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .azure/app-cloud-e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ pr:
- ".actions/**"
- ".azure/app-cloud-e2e.yml"
- "src/lightning_app/**"
- "examples/app_*/**" # some tests_app tests call examples files
- "requirements/app/**"
- "tests/tests_examples_app/**"
- "setup.py"
Expand Down Expand Up @@ -94,8 +93,8 @@ jobs:
'App: custom_work_dependencies':
name: "custom_work_dependencies"
dir: "local"
timeoutInMinutes: "20"
cancelTimeoutInMinutes: "2"
timeoutInMinutes: "10"
cancelTimeoutInMinutes: "1"
# values: https://docs.microsoft.com/en-us/azure/devops/pipelines/process/phases?view=azure-devops&tabs=yaml#workspace
workspace:
clean: all
Expand Down Expand Up @@ -165,7 +164,7 @@ jobs:
ls -l examples/${TEST_APP_NAME}
ls -l tests/tests_examples_app/public
python -m pytest tests/tests_examples_app/${TEST_APP_FOLDER}/test_${TEST_APP_NAME}.py::test_${TEST_APP_NAME}_example_cloud \
--timeout=1200 --capture=no -v --color=yes
--timeout=540 --capture=no -v --color=yes
env:
HEADLESS: '1'
PACKAGE_LIGHTNING: '1'
Expand Down
2 changes: 1 addition & 1 deletion .azure/gpu-benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ pr:
- "tests/tests_pytorch/benchmarks/**"
- "requirements/pytorch/**"
exclude:
- "requirements/pytorch/docs.txt"
- "requirements/*/docs.txt"
- "*.md"
- "**/*.md"

Expand Down
2 changes: 1 addition & 1 deletion .azure/gpu-tests-lite.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ pr:
- "tests/tests_lite/**"
- "setup.cfg" # includes pytest config
exclude:
- "requirements/lite/docs.txt"
- "requirements/*/docs.txt"
- "*.md"
- "**/*.md"

Expand Down
63 changes: 33 additions & 30 deletions .github/checkgroup.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ subprojects:

- id: "pytorch_lightning: Tests workflow"
paths:
- ".actions/**"
- ".github/workflows/ci-pytorch-tests.yml"
- "requirements/lite/**"
- "src/lightning_lite/**"
Expand All @@ -13,8 +14,7 @@ subprojects:
- "tests/tests_pytorch/**"
- "tests/legacy/back-compatible-versions.txt"
- "setup.cfg" # includes pytest config
- ".actions/**"
- "!requirements/**/docs.txt"
- "!requirements/*/docs.txt"
- "!*.md"
- "!**/*.md"
checks:
Expand All @@ -40,6 +40,7 @@ subprojects:

- id: "pytorch_lightning: Azure GPU"
paths:
- ".actions/**"
- ".azure/gpu-tests-pytorch.yml"
# only the azure GPU workflow runs the examples
# all examples don't need to be added because they aren't used in CI, but these are
Expand All @@ -55,8 +56,8 @@ subprojects:
- "setup.cfg" # includes pytest config
- "requirements/lite/**"
- "src/lightning_lite/**"
- ".actions/**"
- "!requirements/**/docs.txt"
- "!requirements/docs.txt"
- "!requirements/*/docs.txt"
- "!*.md"
- "!**/*.md"
checks:
Expand All @@ -75,6 +76,7 @@ subprojects:

- id: "pytorch_lightning: Azure HPU"
paths:
- ".actions/**"
- ".azure/hpu-tests.yml"
- "examples/pl_hpu/mnist_sample.py"
- "requirements/lite/**"
Expand All @@ -83,24 +85,24 @@ subprojects:
- "src/pytorch_lightning/**"
- "tests/tests_pytorch/**"
- "setup.cfg" # includes pytest config
- ".actions/**"
- "!requirements/**/docs.txt"
- "!requirements/*/docs.txt"
- "!*.md"
- "!**/*.md"
checks:
- "pytorch-lightning (HPUs)"

- id: "pytorch_lightning: Azure IPU"
paths:
- ".actions/**"
- ".azure/ipu-tests.yml"
- "requirements/lite/**"
- "src/lightning_lite/**"
- "requirements/pytorch/**"
- "src/pytorch_lightning/**"
- "tests/tests_pytorch/**"
- "setup.cfg" # includes pytest config
- ".actions/**"
- "!requirements/**/docs.txt"
- "!requirements/docs.txt"
- "!requirements/*/docs.txt"
- "!*.md"
- "!**/*.md"
checks:
Expand All @@ -109,6 +111,7 @@ subprojects:
# TODO: since this job has intermittent availability, it cannot be required
#- id: "pytorch-lightning: TPU workflow"
# paths:
# - ".actions/**"
# - ".github/workflows/tpu-tests.yml"
# - "dockers/base-xla/*"
# - "requirements/lite/**"
Expand All @@ -118,8 +121,7 @@ subprojects:
# - "src/pytorch_lightning/**"
# - "tests/tests_pytorch/**"
# - "setup.cfg" # includes pytest config
# - ".actions/**"
# - "!requirements/**/docs.txt"
# - "!requirements/*/docs.txt"
# - "!*.md"
# - "!**/*.md"
# checks:
Expand All @@ -129,12 +131,12 @@ subprojects:
paths:
- "src/pytorch_lightning/**"
- "docs/source-pytorch/**"
- ".actions/**"
- ".github/workflows/docs-checks.yml"
- "requirements/docs.txt"
- "requirements/pytorch/**"
- "setup.py"
- "setup.cfg" # includes metadata used in the package creation
- ".actions/**"
- "!*.md"
- "!**/*.md"
checks:
Expand All @@ -143,14 +145,14 @@ subprojects:

- id: "pytorch_lightning: Docker"
paths:
- "dockers/**"
- ".actions/**"
- ".github/workflows/ci-pytorch-dockers.yml"
- "dockers/**"
- "requirements/pytorch/**"
- "requirements/lite/**"
- "environment.yml"
- "setup.py"
- ".actions/**"
- "!requirements/**/docs.txt"
- "!requirements/*/docs.txt"
- "!*.md"
- "!**/*.md"
checks:
Expand All @@ -171,13 +173,13 @@ subprojects:

- id: "lightning_lite: CPU workflow"
paths:
- ".actions/**"
- "requirements/lite/**"
- "src/lightning_lite/**"
- "tests/tests_lite/**"
- "setup.cfg" # includes pytest config
- ".github/workflows/ci-lite-tests.yml"
- ".actions/**"
- "!requirements/lite/docs.txt"
- "!requirements/*/docs.txt"
- "!*.md"
- "!**/*.md"
checks:
Expand All @@ -200,6 +202,7 @@ subprojects:

- id: "lightning_lite: Azure GPU"
paths:
- ".actions/**"
- ".azure/gpu-tests-lite.yml"
- "examples/lite/**"
- "examples/run_lite_examples.sh"
Expand All @@ -209,8 +212,7 @@ subprojects:
- "src/lightning_lite/**"
- "tests/tests_lite/**"
- "setup.cfg" # includes pytest config
- ".actions/**"
- "!requirements/lite/docs.txt"
- "!requirements/*/docs.txt"
- "!*.md"
- "!**/*.md"
checks:
Expand All @@ -220,13 +222,13 @@ subprojects:

- id: "lightning_app: Tests workflow"
paths:
- ".actions/**"
- ".github/workflows/ci-app-tests.yml"
- "src/lightning_app/**"
- "tests/tests_app/**"
- "requirements/app/**"
- "setup.py"
- ".actions/**"
- "!requirements/app/docs.txt"
- "!requirements/*/docs.txt"
- "!*.md"
- "!**/*.md"
checks:
Expand All @@ -242,14 +244,14 @@ subprojects:

- id: "lightning_app: Examples"
paths:
- ".actions/**"
- ".github/workflows/ci-app-examples.yml"
- "src/lightning_app/**"
- "tests/tests_examples_app/**"
- "examples/app_*/**"
- "requirements/app/**"
- "setup.py"
- ".actions/**"
- "!requirements/app/docs.txt"
- "!requirements/*/docs.txt"
- "!*.md"
- "!**/*.md"
checks:
Expand All @@ -265,29 +267,28 @@ subprojects:

- id: "lightning_app: Azure"
paths:
- ".actions/**"
- ".azure/app-cloud-e2e.yml"
- "requirements/app/**"
- "src/lightning_app/**"
- "examples/app_*/**" # some tests_app tests call examples files
- "requirements/app/**"
- "tests/tests_examples_app/**"
- "setup.py"
- ".actions/**"
- "!requirements/app/docs.txt"
- "!requirements/*/docs.txt"
- "!*.md"
- "!**/*.md"
checks:
- "App.cloud-e2e"

- id: "lightning_app: Docs"
paths:
- ".actions/**"
- "src/lightning_app/**"
- "docs/source-app/**"
- ".github/workflows/docs-checks.yml"
- "requirements/docs.txt"
- "requirements/app/**"
- "setup.py"
- "setup.cfg" # includes metadata used in the package creation
- ".actions/**"
- "!*.md"
- "!**/*.md"
checks:
Expand All @@ -298,12 +299,13 @@ subprojects:

- id: "mypy"
paths:
- ".actions/**"
- ".github/workflows/code-checks.yml"
- "requirements/**"
- "src/**"
- "pyproject.toml" # includes mypy config
- ".actions/**"
- "!requirements/**/docs.txt"
- "!requirements/docs.txt"
- "!requirements/*/docs.txt"
- "!*.md"
- "!**/*.md"
checks:
Expand All @@ -316,7 +318,8 @@ subprojects:
- "setup.py"
- "src/**"
- "requirements/**"
- "!requirements/**/docs.txt"
- "!requirements/docs.txt"
- "!requirements/*/docs.txt"
- "!*.md"
- "!**/*.md"
checks:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ci-app-examples.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,14 @@ on:
branches: [master, "release/*"]
types: [opened, reopened, ready_for_review, synchronize] # added `ready_for_review` since draft is skipped
paths:
- ".actions/**"
- ".github/workflows/ci-app-examples.yml"
- "src/lightning_app/**"
- "tests/tests_examples_app/**"
- "examples/app_*/**"
- "requirements/app/**"
- "setup.py"
- ".actions/**"
- "!requirements/app/docs.txt"
- "!requirements/*/docs.txt"
- "!*.md"
- "!**/*.md"

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ci-app-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@ on:
branches: [master, "release/*"]
types: [opened, reopened, ready_for_review, synchronize] # added `ready_for_review` since draft is skipped
paths:
- ".actions/**"
- ".github/workflows/ci-app-tests.yml"
- "src/lightning_app/**"
- "tests/tests_app/**"
- "requirements/app/**"
- "setup.py"
- ".actions/**"
- "!requirements/app/docs.txt"
- "!requirements/*/docs.txt"
- "!*.md"
- "!**/*.md"

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ci-lite-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@ on:
branches: [master, "release/*"]
types: [opened, reopened, ready_for_review, synchronize] # added `ready_for_review` since draft is skipped
paths:
- ".actions/**"
- "requirements/lite/**"
- "src/lightning_lite/**"
- "tests/tests_lite/**"
- "setup.cfg" # includes pytest config
- ".github/workflows/ci-lite-tests.yml"
- ".actions/**"
- "!requirements/lite/docs.txt"
- "!requirements/*/docs.txt"
- "!*.md"
- "!**/*.md"

Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/ci-pkg-install.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ on:
- "setup.py"
- "src/**"
- "requirements/**"
- "!requirements/**/docs.txt"
- "!requirements/docs.txt"
- "!requirements/*/docs.txt"
- "!*.md"
- "!**/*.md"

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/ci-pytorch-dockers.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@ on:
branches: [master, "release/*"]
types: [opened, reopened, ready_for_review, synchronize] # added `ready_for_review` since draft is skipped
paths:
- "dockers/**"
- ".actions/**"
- ".github/workflows/ci-pytorch-dockers.yml"
- "dockers/**"
- "requirements/pytorch/**"
- "requirements/lite/**"
- "environment.yml"
- "setup.py"
- ".actions/**"
- "!requirements/**/docs.txt"
- "!requirements/*/docs.txt"
- "!*.md"
- "!**/*.md"
schedule:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ci-pytorch-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ on:
branches: [master, "release/*"]
types: [opened, reopened, ready_for_review, synchronize] # added `ready_for_review` since draft is skipped
paths:
- ".actions/**"
- "requirements/pytorch/**"
- "src/pytorch_lightning/**"
- "tests/tests_pytorch/**"
Expand All @@ -16,8 +17,7 @@ on:
- ".github/workflows/ci-pytorch-tests.yml"
- "requirements/lite/**"
- "src/lightning_lite/**"
- ".actions/**"
- "!requirements/**/docs.txt"
- "!requirements/pytorch/docs.txt"
- "!*.md"
- "!**/*.md"

Expand Down
Loading