Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in CI/CD doc #13196

Merged
merged 7 commits into from
Jun 22, 2022
Merged

Fix typo in CI/CD doc #13196

merged 7 commits into from
Jun 22, 2022

Conversation

ekagra-ranjan
Copy link
Contributor

What does this PR do?

Fix typo in CI CD doc

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • [n/a] Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@ekagra-ranjan ekagra-ranjan changed the title Fix typo in ci cd doc Fix typo in CI/CD doc Jun 1, 2022
@carmocca carmocca added the docs Documentation related label Jun 1, 2022
@carmocca carmocca added this to the 1.7 milestone Jun 1, 2022
@mergify mergify bot added the ready PRs ready to be merged label Jun 1, 2022
@mergify mergify bot requested a review from a team June 1, 2022 17:02
awaelchli
awaelchli approved these changes Jun 2, 2022
View reviewed changes
Borda
Borda approved these changes Jun 2, 2022
View reviewed changes
awaelchli
awaelchli approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this?

@Borda Borda enabled auto-merge (squash) June 21, 2022 21:57
@Borda Borda merged commit 36dffb8 into Lightning-AI:master Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmocca carmocca carmocca approved these changes

@akihironitta akihironitta akihironitta approved these changes

@awaelchli awaelchli awaelchli approved these changes

@Borda Borda Borda approved these changes

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

Assignees
No one assigned
Labels
docs Documentation related ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.7
Development

Successfully merging this pull request may close these issues.
5 participants
@ekagra-ranjan @awaelchli @Borda @carmocca @akihironitta