-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce predict_epoch_end hook to LightningModule for being c… #13143
feat: introduce predict_epoch_end hook to LightningModule for being c… #13143
Conversation
…onsistent with other API
Might |
Should outputs be deprecated in v1.6 and removed in v1.8? |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions. |
This pull request is going to be closed. Please feel free to reopen it create a new from the actual master. |
What does this PR do?
Fixes #8479
outputs
argument from on_predict_epoch_end is deprecated hereintroduce
predict_epoch_end
method to LightningModule hereThe prediction loop to cache prediction if
prediction_epoch_end
is implemented. To realize that,should_store_predictions
property is deprecated and will be taken the place by_should_track_batch_outputs_for_epoch_end
Does your PR introduce any breaking changes? If yes, please list them.
None.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃