Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce predict_epoch_end hook to LightningModule for being c… #13143

Conversation

ishtos
Copy link
Contributor

@ishtos ishtos commented May 24, 2022

What does this PR do?

Fixes #8479

Does your PR introduce any breaking changes? If yes, please list them.

None.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@ishtos
Copy link
Contributor Author

ishtos commented May 24, 2022

Might BasePredictionWriter be deprecated as well when prediction loop will cache outputs depends on whether predict_epoch_end is implemented or not?

@ishtos ishtos requested a review from rohitgr7 as a code owner May 25, 2022 12:51
@ishtos ishtos marked this pull request as draft May 25, 2022 12:55
@ishtos
Copy link
Contributor Author

ishtos commented May 26, 2022

Should outputs be deprecated in v1.6 and removed in v1.8?

@ishtos ishtos marked this pull request as ready for review May 27, 2022 01:08
@stale
Copy link

stale bot commented Jun 11, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Jun 11, 2022
@stale stale bot removed the won't fix This will not be worked on label Jun 21, 2022
@mergify mergify bot removed the has conflicts label Jun 27, 2022
@stale
Copy link

stale bot commented Jul 12, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Jul 12, 2022
@stale
Copy link

stale bot commented Jul 22, 2022

This pull request is going to be closed. Please feel free to reopen it create a new from the actual master.

@stale stale bot closed this Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
won't fix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent API for on_predict_epoch_end
2 participants