Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update NGC docker #13136

Merged
merged 5 commits into from
Jun 2, 2022
Merged

update NGC docker #13136

merged 5 commits into from
Jun 2, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented May 24, 2022 •
edited by github-actions bot
Loading

What does this PR do?

update docker image for NGC

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @carmocca @akihironitta @Borda

@Borda Borda added this to the 1.6.x milestone May 24, 2022
@Borda Borda marked this pull request as ready for review May 24, 2022 09:57
@Borda Borda requested review from tchaton and carmocca as code owners May 24, 2022 09:57
@Borda Borda requested review from akihironitta, kaushikb11 and a team May 24, 2022 09:57
carmocca
carmocca approved these changes May 24, 2022
View reviewed changes
dockers/release/Dockerfile Outdated Show resolved Hide resolved
dockers/nvidia/Dockerfile Show resolved Hide resolved
@carmocca carmocca added the ci Continuous Integration label May 24, 2022
akihironitta
akihironitta approved these changes May 24, 2022
View reviewed changes
dockers/nvidia/Dockerfile Outdated Show resolved Hide resolved
dockers/nvidia/Dockerfile Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label May 24, 2022
@mergify mergify bot requested a review from a team May 24, 2022 11:47
Borda and others added 2 commits May 24, 2022 13:49
@Borda @akihironitta @carmocca
Apply suggestions from code review
42c676c 
Co-authored-by: Akihiro Nitta <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
@Borda
strategy
32163b1
@Borda Borda enabled auto-merge (squash) May 24, 2022 12:02
@Borda Borda merged commit de4ab1c into master Jun 2, 2022
@Borda Borda deleted the docker/ngc branch June 2, 2022 12:54
@rohitgr7 rohitgr7 mentioned this pull request Jul 1, 2022
Merged
12 tasks
rohitgr7 pushed a commit that referenced this pull request Jul 1, 2022
@Borda @akihironitta
@carmocca @rohitgr7
update NGC docker (#13136)
e95b3e8 
* update docker
* Apply suggestions from code review

Co-authored-by: Akihiro Nitta <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
lexierule pushed a commit that referenced this pull request Jul 12, 2022
@rohitgr7 @Borda
@akihironitta @carmocca @dependabot @adamjstewart @awaelchli @martinosorb
Weekly patch release v1.6.5 (#13481)
ff53616 
* update NGC docker (#13136)

* update docker
* Apply suggestions from code review

Co-authored-by: Akihiro Nitta <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>

* Decouple pulling legacy checkpoints from existing GHA workflows and docker files (#13185)

* Add pull-legacy-checkpoints action
* Replace pulls with the new action and script
* Simplify

* Merge pull request #13250 from PyTorchLightning/ci/rm-base

CI: Remove simple test `ci_test-base.yml`

* Update rich requirement from !=10.15.*,<=12.0.0,>=10.2.2 to >=10.2.2,!=10.15.0.a,<13.0.0 in /requirements (#13047)

* Update rich requirement in /requirements

Updates the requirements on [rich](https://github.com/willmcgugan/rich) to permit the latest version.
- [Release notes](https://github.com/willmcgugan/rich/releases)
- [Changelog](https://github.com/Textualize/rich/blob/master/CHANGELOG.md)
- [Commits](Textualize/rich@v10.2.2...v12.4.1)

---
updated-dependencies:
- dependency-name: rich
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

* Fix torch.distributed._sharded_tensor DeprecationWarning (#13261)

* update tutorials (#13268)

* [BUG] `estimated_stepping_batches` requires distributed comms in `configure_optimizers` for `DeepSpeedStrategy` (#13350)

* Update torchmetrics requirement from <=0.7.2,>=0.4.1 to >=0.4.1,<0.9.2 in /requirements (#13275)

Update torchmetrics requirement in /requirements

Updates the requirements on [torchmetrics](https://github.com/PyTorchLightning/metrics) to permit the latest version.
- [Release notes](https://github.com/PyTorchLightning/metrics/releases)
- [Changelog](https://github.com/PyTorchLightning/metrics/blob/master/CHANGELOG.md)
- [Commits](Lightning-AI/torchmetrics@v0.4.1...v0.9.1)

---
updated-dependencies:
- dependency-name: torchmetrics
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix mypy errors for model summary utilities (#13384)

* rename org Lightning AI

* Modified python version check to accommodate for legacy version styles (#13420)

Co-authored-by: Carlos Mocholí <[email protected]>

(cherry picked from commit b332b66)

* Call `set_epoch` for distributed batch samplers (#13396)

Co-authored-by: Jirka <[email protected]>
Co-authored-by: Rohit Gupta <[email protected]>

(cherry picked from commit 2dd332f)

* _RICH_AVAILABLE

* _FAIRSCALE_AVAILABLE

* _BAGUA_AVAILABLE

* redefine

* chlog spaces

* CI: Fix `fatal: unsafe repository` (#13515)

* update release date

* CI: azure rename

* Restore log step during restart (#13467)

Co-authored-by: Carlos Mocholí <[email protected]>

* remove redundant test

* Update CI setup (#13291)

* drop mamba
* use legacy GPU machines

* fix schema check

Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Akihiro Nitta <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Adam J. Stewart <[email protected]>
Co-authored-by: Sean Naren <[email protected]>
Co-authored-by: Adrian Wälchli <[email protected]>
Co-authored-by: Jirka <[email protected]>
Co-authored-by: Martino Sorbaro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmocca carmocca carmocca approved these changes

@akihironitta akihironitta akihironitta approved these changes

@kaushikb11 kaushikb11 kaushikb11 approved these changes

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

Assignees

@Borda Borda

Labels
ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.6.x
Development

Successfully merging this pull request may close these issues.
4 participants
@Borda @carmocca @akihironitta @kaushikb11