-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typing to LightningModule.trainer
#12345
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added typing for the trainer pointer within a LightningModule
johnhenning
requested review from
williamFalcon,
tchaton and
awaelchli
as code owners
March 16, 2022 15:42
rohitgr7
reviewed
Mar 16, 2022
johnhenning
commented
Mar 16, 2022
Co-authored-by: Rohit Gupta <[email protected]>
rohitgr7
approved these changes
Mar 17, 2022
awaelchli
approved these changes
Mar 19, 2022
carmocca
reviewed
Mar 21, 2022
Borda
approved these changes
Mar 21, 2022
carmocca
suggested changes
Mar 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please ping me when the mypy job is green!
Thank you for your work.
auto-merge was automatically disabled
March 22, 2022 17:40
Head branch was pushed to by a user without write access
johnhenning
requested review from
SeanNaren,
justusschock and
kaushikb11
as code owners
March 22, 2022 17:40
@carmocca Mypy is fixed! |
carmocca
approved these changes
Mar 25, 2022
rohitgr7
reviewed
Mar 25, 2022
carmocca
force-pushed
the
trainer-typing
branch
from
March 29, 2022 02:08
e98139e
to
c671041
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a small change that adds typing to the trainer object within the LightningModule.
Fixes #12337
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃