-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add usage of Jupyter magic command for loggers #12333
Add usage of Jupyter magic command for loggers #12333
Conversation
I've made the suggested changes and pulled the commits from master to this branch to get it up-to-date |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @manangoel99 - Thanks for the PR! Left a minor comment, but also curious: from the description of this PR: This PR rearranges the logger documentation and adds usage of jupyter magic command for wandb
.
Can you please point me to the change (line of code) which adds usage of jupyter magic command for wandb in this PR? Got it! :)
I'm also concerned about re-arranging, unless and until it was discussed in an issue before or has a reason that everyone agrees with (if it was discussed before, please feel free to point me to the discussion :)). cc: @kaushikb11 @awaelchli @Borda
I've put everything back in the alphabetical order and added usage of the |
Thanks, @manangoel99 for updating this PR. Appreciate the contribution. Just FYI (apart from @rohitgr7's comments) - I updated the description and title of this PR, feel free to make further edits if any changes required. :) |
wandb
wandb
wandb
(docs)
Co-authored-by: Rohit Gupta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@manangoel99 Could we document a magic command for tensorboard as well in this PR?
That would be a good addition, thanks @akihironitta for suggesting this. @manangoel99 - if you feel comfortable doing it in this PR, that would be great, but if you want to do it in another PR, that's totally fine as well. Just let us know :) |
lets add it here |
@krshrimali @rohitgr7 Thanks for adding this to the PR. I actually found the Tensorboard instructions elsewhere so I skipped those initially. Absolutely no issues in adding it to this PR! |
yep! I noticed. But we will probably remove tensorboard as default in the future so the existing one will be updated then. |
wandb
(docs)Co-authored-by: Adrian Wälchli <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @manangoel99 for your contribution.
@manangoel99 There are some docs failures:
cc @rohitgr7 (if you know what's the cause) |
What does this PR do?
This PR adds usage of a jupyter magic command for wandb
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃