-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update has_len_all_ranks
to use Strategy.root_device
#12144
Conversation
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions. |
Co-authored-by: Carlos Mocholí <[email protected]>
for more information, see https://pre-commit.ci
ff6f2a4
to
42a19d5
Compare
The CPU test failures are real: FAILED trainer/properties/test_estimated_stepping_batches.py::test_num_stepping_batches_gpu[trainer_kwargs0-10]
FAILED trainer/properties/test_estimated_stepping_batches.py::test_num_stepping_batches_gpu[trainer_kwargs1-5]
FAILED trainer/properties/test_estimated_stepping_batches.py::test_num_stepping_batches_gpu[trainer_kwargs2-4]
FAILED trainer/properties/test_estimated_stepping_batches.py::test_num_stepping_batches_gpu[trainer_kwargs3-3]
FAILED trainer/properties/test_estimated_stepping_batches.py::test_num_stepping_batches_gpu[trainer_kwargs4-64] cc @rohitgr7 |
patched it |
What does this PR do?
Same motivation as #11734
Part of #11922
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda @justusschock @awaelchli @rohitgr7 @ninginthecloud @otaj