Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update has_len_all_ranks to use Strategy.root_device #12144

Merged
merged 8 commits into from
Aug 29, 2022

Conversation

ananthsub
Copy link
Contributor

@ananthsub ananthsub commented Feb 28, 2022

What does this PR do?

Same motivation as #11734
Part of #11922

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @justusschock @awaelchli @rohitgr7 @ninginthecloud @otaj

@ananthsub ananthsub added refactor data handling Generic data-related topic labels Feb 28, 2022
@mergify mergify bot added the ready PRs ready to be merged label Mar 12, 2022
@awaelchli awaelchli enabled auto-merge (squash) March 12, 2022 03:55
@stale
Copy link

stale bot commented Apr 16, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Apr 16, 2022
@carmocca carmocca removed the won't fix This will not be worked on label Apr 21, 2022
@carmocca carmocca removed the ready PRs ready to be merged label May 13, 2022
@mergify mergify bot added the ready PRs ready to be merged label May 13, 2022
@stale
Copy link

stale bot commented Jun 5, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Jun 5, 2022
@carmocca carmocca self-assigned this Jun 6, 2022
@stale stale bot removed the won't fix This will not be worked on label Jun 6, 2022
@carmocca carmocca force-pushed the ananthsub-patch-5 branch from ff6f2a4 to 42a19d5 Compare June 6, 2022 16:30
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Jun 15, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 27, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Aug 27, 2022
@awaelchli awaelchli added this to the pl:1.8 milestone Aug 27, 2022
@carmocca
Copy link
Contributor

The CPU test failures are real:

FAILED trainer/properties/test_estimated_stepping_batches.py::test_num_stepping_batches_gpu[trainer_kwargs0-10]
FAILED trainer/properties/test_estimated_stepping_batches.py::test_num_stepping_batches_gpu[trainer_kwargs1-5]
FAILED trainer/properties/test_estimated_stepping_batches.py::test_num_stepping_batches_gpu[trainer_kwargs2-4]
FAILED trainer/properties/test_estimated_stepping_batches.py::test_num_stepping_batches_gpu[trainer_kwargs3-3]
FAILED trainer/properties/test_estimated_stepping_batches.py::test_num_stepping_batches_gpu[trainer_kwargs4-64]

cc @rohitgr7

@carmocca carmocca assigned rohitgr7 and unassigned carmocca Aug 29, 2022
@rohitgr7
Copy link
Contributor

The CPU test failures are real:

FAILED trainer/properties/test_estimated_stepping_batches.py::test_num_stepping_batches_gpu[trainer_kwargs0-10]
FAILED trainer/properties/test_estimated_stepping_batches.py::test_num_stepping_batches_gpu[trainer_kwargs1-5]
FAILED trainer/properties/test_estimated_stepping_batches.py::test_num_stepping_batches_gpu[trainer_kwargs2-4]
FAILED trainer/properties/test_estimated_stepping_batches.py::test_num_stepping_batches_gpu[trainer_kwargs3-3]
FAILED trainer/properties/test_estimated_stepping_batches.py::test_num_stepping_batches_gpu[trainer_kwargs4-64]

cc @rohitgr7

patched it

@awaelchli awaelchli merged commit d0d1818 into master Aug 29, 2022
@awaelchli awaelchli deleted the ananthsub-patch-5 branch August 29, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data handling Generic data-related topic pl Generic label for PyTorch Lightning package ready PRs ready to be merged refactor
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants