Fix SaveConfigCallback
with ddp spawn
#11987
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A CLI test using different strategies (ddp spawn, ddp) was silently broken accidentally in this PR:
https://github.com/PyTorchLightning/pytorch-lightning/pull/9931/files#diff-99e49066f136ed08cfc2c4ed81ff44eb71414ab3e600a62d278e4bd613a67997R584-R585
due to a bug in the
AcceleratorConnector
Since the test was not working as expected, #10896 broke the
SaveConfigCallback
without noticing because nowsetup
is called AFTER processes are spawned.Then, #11448 fixed the
AcceleratorConnector
bug which uncovered the failing CLI test.This PR fixes the test and uses an internal hook (aka a hack) to support DDP spawn again.
Note that the bug is unreleased.
A longer-term fix will be to make
ArgumentParser
pickleable or to have the parser expose a static save function. @mauvilsaDoes your PR introduce any breaking changes? If yes, please list them.
None.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
cc @carmocca @mauvilsa @justusschock @kaushikb11 @awaelchli @akihironitta @rohitgr7