Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use root_device in DeviceStatsMonitor callback #11748

Merged
merged 2 commits into from
Feb 5, 2022
Merged

Conversation

ananthsub
Copy link
Contributor

@ananthsub ananthsub commented Feb 5, 2022

Minor refactor to use the strategy's own root_device instead of the LightningModule's device property.

Attempts at manual model parallelization will face difficulties with the assumption that the LightningModule has a well-defined device property. Not all of the model parameters will be on the same device.

For those use cases, it is critical to remove the assumption that the module has a device property (device on the module in general goes against PyTorch's design principles:

What does this PR do?

Does your PR introduce any breaking changes? If yes, please list them.

No

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @justusschock @awaelchli @akihironitta @rohitgr7 @kaushikb11

…n DeviceStatsMonitor

Minor refactor to use the strategy's own `root_device` instead of the LightningModule's device property.

Attempts at manual model parallelization by extending this plugin will face difficulties with the assumption that the LightningModule has all of its parameters on the same device. 

For those use cases, it is critical to remove the assumption that the module has a device property (device in general goes against PyTorch module's design principles:
- pytorch/pytorch#7460
- #1790 (comment)
@ananthsub ananthsub added this to the 1.6 milestone Feb 5, 2022
@ananthsub ananthsub changed the title Use trainer.strategy.root_device in DeviceStatsMonitor callback Use root_device in DeviceStatsMonitor callback Feb 5, 2022
@mergify mergify bot added the ready PRs ready to be merged label Feb 5, 2022
@Borda Borda merged commit 7d9454a into master Feb 5, 2022
@Borda Borda deleted the ananthsub-patch-2 branch February 5, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants