Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing Win failed import #1163

Merged
merged 3 commits into from
Mar 17, 2020
Merged

fixing Win failed import #1163

merged 3 commits into from
Mar 17, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Mar 16, 2020 •
edited
Loading

What does this PR do?

Fixing the failing imports on Windows, see:

c:\hostedtoolcache\windows\python\3.6.8\x64\lib\site-packages\py\_path\local.py:701: in pyimport
    __import__(modname)
pytorch_lightning\__init__.py:27: in <module>
    from .core import LightningModule
pytorch_lightning\core\__init__.py:316: in <module>
    from .lightning import LightningModule
pytorch_lightning\core\lightning.py:12: in <module>
    from torch.distributed import init_process_group
E   ImportError: cannot import name 'init_process_group'

minor: Reduce nb calling rebase actions and also state version as develop

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the ci Continuous Integration label Mar 16, 2020
@Borda Borda added this to the 0.7.2 milestone Mar 16, 2020
@Borda Borda requested a review from williamFalcon March 16, 2020 18:54
@Borda Borda added the bug Something isn't working label Mar 16, 2020
@Borda Borda requested review from a team and removed request for williamFalcon March 16, 2020 19:15
@Borda Borda changed the title reduce rebase action & version fixing Win failed import Mar 16, 2020
@Borda Borda added the priority: 0 High priority task label Mar 16, 2020
@Borda Borda mentioned this pull request Mar 16, 2020
Closed
5 tasks
neggert
neggert approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@neggert neggert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just so we're all clear, distributed mode is not supported on Windows (by PyTorch). This fix doesn't make distributed mode work, it just makes it so that the core code doesn't try to import functions that don't exist on Windows.

To be clear, I think this is the correct thing to do.

@Borda Borda requested review from williamFalcon and a team March 16, 2020 21:10
@Borda Borda mentioned this pull request Mar 16, 2020
Merged
@Borda Borda added the ready PRs ready to be merged label Mar 16, 2020
This was referenced Mar 16, 2020
Merged
Merged
Merged
@williamFalcon williamFalcon merged commit e461ec0 into Lightning-AI:master Mar 17, 2020
williamFalcon added a commit that referenced this pull request Mar 17, 2020
@williamFalcon @Borda
coverage increase (#1167)
c32e3f3 
* fixed docs

* Docs (#1164)

* fixed docs

* fixed docs

* fixed docs

* fixing Win failed import (#1163)

* version

* try fix distrib

* update try import

* fixed docs

Co-authored-by: Jirka Borovec <[email protected]>
@Borda Borda deleted the reduce-rebase branch March 17, 2020 07:15
Borda added a commit that referenced this pull request Mar 17, 2020
@williamFalcon @Borda
coverage increase (#1167)
8de7b40 
* fixed docs

* Docs (#1164)

* fixed docs

* fixed docs

* fixed docs

* fixing Win failed import (#1163)

* version

* try fix distrib

* update try import

* fixed docs

Co-authored-by: Jirka Borovec <[email protected]>
@Borda Borda mentioned this pull request Mar 17, 2020
Merged
5 tasks
tullie pushed a commit to tullie/pytorch-lightning that referenced this pull request Apr 3, 2020
@Borda @tullie
fixing Win failed import (Lightning-AI#1163)
94f3c9d 
* version

* try fix distrib

* update try import
tullie pushed a commit to tullie/pytorch-lightning that referenced this pull request Apr 3, 2020
@williamFalcon @Borda @tullie
coverage increase (Lightning-AI#1167)
0a81027 
* fixed docs

* Docs (Lightning-AI#1164)

* fixed docs

* fixed docs

* fixed docs

* fixing Win failed import (Lightning-AI#1163)

* version

* try fix distrib

* update try import

* fixed docs

Co-authored-by: Jirka Borovec <[email protected]>
@Borda Borda modified the milestones: v0.7., v0.7.x Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neggert neggert neggert approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees
No one assigned
Labels
bug Something isn't working ci Continuous Integration priority: 0 High priority task ready PRs ready to be merged
Projects
None yet
Milestone
pl:0.7.x
Development

Successfully merging this pull request may close these issues.
3 participants
@Borda @neggert @williamFalcon