-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tests/models/*.py
to use devices
instead of gpus
or ipus
#11470
Conversation
A lot of the tests in |
Also, it may be apparent from called == expected I didn't want to implement any major changes until I got input from yall |
I deleted a few tests from |
Nvm, figured this out |
Decided to sunset some tests. |
tensorboard is failing? |
@mathemusician that is a known issue not related to your PR: pytorch/pytorch#69904 |
Thanks @rohitgr7! Those TPU tests took me on a roller coaster ride to nowhere. |
What does this PR do?
Update test to deprecate
num_processes
,gpus
,tpu_cores
, andipus
from the Trainer constructorPart of Pull 11040.
🌳 Trello Board Link
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃