Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Lite docs #10347

Merged
merged 2 commits into from
Nov 5, 2021
Merged

Update Lite docs #10347

merged 2 commits into from
Nov 5, 2021

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Nov 4, 2021

What does this PR do?

My review of #10176

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added docs Documentation related fabric lightning.fabric.Fabric labels Nov 4, 2021
@carmocca carmocca added this to the v1.6 milestone Nov 4, 2021
@carmocca carmocca self-assigned this Nov 4, 2021
Borda
Borda approved these changes Nov 4, 2021
View reviewed changes
@mergify mergify bot added the ready PRs ready to be merged label Nov 4, 2021
@mergify mergify bot requested a review from a team November 4, 2021 10:19
@carmocca @Borda @s-rog
Apply suggestions from code review
001c57e 
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Roger Shieh <[email protected]>
@carmocca carmocca enabled auto-merge (squash) November 5, 2021 03:14
@carmocca carmocca merged commit a501cd3 into master Nov 5, 2021
@carmocca carmocca deleted the docs/lite branch November 5, 2021 03:50
Raalsky pushed a commit to neptune-ai/pytorch-lightning that referenced this pull request Nov 23, 2021
@carmocca @Borda
@s-rog @Raalsky
Update Lite docs (Lightning-AI#10347)
096f74d 
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Roger Shieh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-rog s-rog s-rog left review comments

@awaelchli awaelchli awaelchli approved these changes

@Borda Borda Borda approved these changes

@justusschock justusschock justusschock approved these changes

@SkafteNicki SkafteNicki SkafteNicki approved these changes

@edenlightning edenlightning Awaiting requested review from edenlightning

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

Assignees

@carmocca carmocca

Labels
docs Documentation related fabric lightning.fabric.Fabric ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.
6 participants
@carmocca @awaelchli @Borda @justusschock @SkafteNicki @s-rog