Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

powersgd #643

Closed
titusnicolae opened this issue Dec 20, 2019 · 13 comments
Closed

powersgd #643

titusnicolae opened this issue Dec 20, 2019 · 13 comments
Assignees
Labels
discussion In a discussion stage feature Is an improvement or enhancement help wanted Open to be worked on waiting on author Waiting on user action, correction, or update

Comments

@titusnicolae
Copy link

Powersgd paper shows promising scaling for distributed training.
https://arxiv.org/abs/1905.13727
I'm interested in porting this to pytorch-lightning, do you think it's a good idea?
Thanks

@titusnicolae titusnicolae added feature Is an improvement or enhancement help wanted Open to be worked on labels Dec 20, 2019
@jeffling
Copy link
Contributor

@titusnicolae I'm a big fan of this. I'm not sure if it needs to be a framework level feature, or if we should find a way to make it easy to plug in. But I would love to see a lightning-compatible implementation of this, whether in a PR or as a separate plugin.

@williamFalcon
Copy link
Contributor

@titusnicolae @soumith this might be better in PyTorch?

@Borda Borda removed the help wanted Open to be worked on label Feb 3, 2020
@Borda
Copy link
Member

Borda commented Mar 26, 2020

@titusnicolae @jeffling any update here?

@Borda Borda added help wanted Open to be worked on discussion In a discussion stage labels Mar 26, 2020
@jeffling
Copy link
Contributor

@titusnicolae any luck on porting this over?

If it could be done in a callback, it should be. otherwise, I think if there is enough proof / demand behind this it would make sense to be in the framework.

@stale
Copy link

stale bot commented May 28, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label May 28, 2020
@Borda Borda removed the won't fix This will not be worked on label May 28, 2020
@stale
Copy link

stale bot commented Jul 27, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Jul 27, 2020
@Borda Borda removed the won't fix This will not be worked on label Jul 27, 2020
@stale
Copy link

stale bot commented Oct 22, 2020

This issue has been automatically marked as stale because it hasn't had any recent activity. This issue will be closed in 7 days if no further activity occurs. Thank you for your contributions, Pytorch Lightning Team!

@stale stale bot added the won't fix This will not be worked on label Oct 22, 2020
@Borda
Copy link
Member

Borda commented Oct 22, 2020

@edenlightning is this in timeline?

@stale stale bot removed the won't fix This will not be worked on label Oct 22, 2020
@tchaton
Copy link
Contributor

tchaton commented Jan 18, 2021

Hey @jeffling,

Any updates ? You could make a PR to add it to Lightning directly.

Best,
T.C

@tchaton
Copy link
Contributor

tchaton commented Mar 9, 2021

Dear @titusnicolae,

PyTorch currently support PowerSGD and it can easily be added by registering builtin DDP Communitation hooks.

Do you want to give it a try ?

Best,
T.C

@tchaton tchaton added the waiting on author Waiting on user action, correction, or update label Mar 9, 2021
@titusnicolae
Copy link
Author

titusnicolae commented Mar 9, 2021 via email

@shuyingsunshine21
Copy link
Contributor

looks like #6727 could cover this scenario :)

@shuyingsunshine21
Copy link
Contributor

@titusnicolae , with #6736, this should be supported

@carmocca carmocca closed this as completed Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion In a discussion stage feature Is an improvement or enhancement help wanted Open to be worked on waiting on author Waiting on user action, correction, or update
Projects
None yet
Development

No branches or pull requests

7 participants