Remove GradInformation module, including from LightningModule hierarc…

…hy (#8831) * Remove GradInformation module from LightningModule hierarchy
Lightning-AI · Aug 19, 2021 · f87b2ef · f87b2ef
1 parent 6de66eb
commit f87b2ef
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 45 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -95,6 +95,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
 
 - `Trainer.request_dataloader` now takes a `RunningStage` enum instance ([#8858](https://github.com/PyTorchLightning/pytorch-lightning/pull/8858))
 
+
 ### Deprecated
 
 - Deprecated `LightningModule.summarize()` in favor of `pytorch_lightning.utilities.model_summary.summarize()`
@@ -143,12 +144,14 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
 - Removed the deprecated `Trainer.truncated_bptt_steps` in favor of `LightningModule.truncated_bptt_steps` ([#8826](https://github.com/PyTorchLightning/pytorch-lightning/pull/8826))
 
 
-- Removed `LightningModule.write_predictions` and `LightningModule.write_predictions_dict` ([#](https://github.com/PyTorchLightning/pytorch-lightning/pull/8850))
+- Removed `LightningModule.write_predictions` and `LightningModule.write_predictions_dict` ([#8850](https://github.com/PyTorchLightning/pytorch-lightning/pull/8850))
 
 
 - Removed reset dataloader hooks to Training Plugins and Accelerators ([#8858](https://github.com/PyTorchLightning/pytorch-lightning/pull/8858))
 
 
+- Removed deprecated `GradInformation` module in favor of `pytorch_lightning.utilities.grads` ([#8831](https://github.com/PyTorchLightning/pytorch-lightning/pull/8831/))
+
 
 ### Fixed
 

diff --git a/pytorch_lightning/core/grads.py b/pytorch_lightning/core/grads.py
diff --git a/pytorch_lightning/core/lightning.py b/pytorch_lightning/core/lightning.py
@@ -31,7 +31,6 @@
 from torch.optim.optimizer import Optimizer
 from torchmetrics import Metric
 
-from pytorch_lightning.core.grads import GradInformation
 from pytorch_lightning.core.hooks import CheckpointHooks, DataHooks, ModelHooks
 from pytorch_lightning.core.mixins import DeviceDtypeModuleMixin, HyperparametersMixin
 from pytorch_lightning.core.optimizer import LightningOptimizer
@@ -57,7 +56,6 @@ class LightningModule(
     ABC,
     DeviceDtypeModuleMixin,
     HyperparametersMixin,
-    GradInformation,
     ModelIO,
     ModelHooks,
     DataHooks,

diff --git a/tests/deprecated_api/test_remove_1-5.py b/tests/deprecated_api/test_remove_1-5.py
@@ -161,12 +161,6 @@ def bar(self):
                 pass
 
 
-def test_v1_5_0_lighting_module_grad_norm(tmpdir):
-    model = BoringModel()
-    with pytest.deprecated_call(match="is deprecated in v1.3 and will be removed in v1.5"):
-        model.grad_norm(2)
-
-
 def test_v1_5_0_datamodule_setter():
     model = BoringModel()
     datamodule = BoringDataModule()