-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plot()
functionality to audio metrics
#1434
Add plot()
functionality to audio metrics
#1434
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
@SkafteNicki @justusschock mind have look 🦦 |
@SkafteNicki I have added plot functionality for all the audio metrics. However, I am unsure about the lower and upper bounds of these metrics. Also, a couple of Github actions are failing, which I suspect is due to some incorrect/insufficient imports. I would appreciate your feedback on the same. |
@shhs29 thanks, I will take a look at it soon. We are experience problems with our CI at the moment, which should hopefully be solved soon also. |
for more information, see https://pre-commit.ci
plot()
functionality to audio metrics
What does this PR do?
Fixes #1406
Currently, plot functionality is added for pesq metric. The test for plotting passes locally. However, the workflows on CI are failing.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃