-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .plot()
to all modular metrics
#1406
Comments
I would be happy to work on this issue |
Interested in working on the Regression and Classification subcategory. |
@ufukhurriyetoglu cool, which category you would like to take?
@srishti-git1110 great, noting it 🐰 |
I would love to work on any subtask as well. |
I am also interested in contributing to any of the subtasks. |
@Borda text and retrieval, and maybe audio if needed at the time we finish the first two. |
@shhs29 cool, so how about audio? |
I was wondering if there was anything left for me to pickup as well? |
sure, there are still Image, Detection and Aggregation 🎁 |
I guess I'll go with Image. |
hi, everyone how was your Xmass break? did you have a chance to look at your tasks? 🦦 |
@Borda Sorry for the lack of communication on this. I will have a draft PR ready latest by Sunday. |
@Borda I am also planning to raise a draft PR by this weekend. Sorry for the delay. |
@Borda Hey, yes! Have been looking into it. This is also my first time contributing to an open source project so a bit overwhelmed at the moment, but I'm on it 💪. Please expect an update within a week from now. |
Hi @Borda, I can work on plotting Detection metrics, do you have any preferences on what should be included? |
hi @Borda targeting a draft PR for |
I kickstarted the |
@Borda @SkafteNicki I have created a draft PR for adding plot to pesq metric. The link to the PR is: #1434. I am looking for some feedback before I move to the next set of metrics. I would appreciate it if you can point me to the contact person for this. |
Hi @shhs29, @srishti-git1110, @venomouscyanide, @ufukhurriyetoglu, how is it going? we would like to get this to the upcoming 0.12 release... |
Hi @Borda, |
@Borda I will definitely have a draft PR open by the weekend. If not, I will resign from this activity to avoid further delays for your team 😄 |
Hi @Borda @SkafteNicki @srishti-git1110: I feel like the classification category is a rather large task. Maybe we can divide it into subcategories? I would be happy to draft a PR for plot support for AUROC and ROC metrics. |
Hi @alexkrz. Great! I'm working on other classification and regression metrics - you can take up AUROC and ROC. |
🚀 Feature
We are in the process of adding native plotting to torchmetrics such that our users can easily create simple plots of metrics, which is especially useful for metrics such as confusion matrix and pr-curves but even single-scalar metrics such as accuracy it can be beneficial to quickly create a plot of computed values.
The first proof of concept PR has just been merged: #1328
We are inviting anyone interested in contributing to torchmetrics to help add this feature to all remaining metrics. The tasks are fairly simple and an example of how to implement the
plot
metric can be seen here: https://github.com/Lightning-AI/metrics/blob/d8caeeb28efc0afb86ae68cf66b06412749a4e46/src/torchmetrics/classification/accuracy.py#L110-L156We would like the work divided into PRs tackling each domain, however if any are interested in only contributing to a few metrics within a particular domain that is also more than welcome.
plot()
functionality to audio metrics #1434 @shhs29plot()
in image metrics #1480 @venomouscyanideplot
to nominal #1581 @SkafteNickiplot
to detection #1585 @SkafteNickiThe text was updated successfully, but these errors were encountered: