Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .plot() to all modular metrics #1406

Closed
11 tasks done
SkafteNicki opened this issue Dec 23, 2022 · 25 comments · Fixed by #1434, #1480 or #1682
Closed
11 tasks done

Add .plot() to all modular metrics #1406

SkafteNicki opened this issue Dec 23, 2022 · 25 comments · Fixed by #1434, #1480 or #1682
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@SkafteNicki
Copy link
Member

SkafteNicki commented Dec 23, 2022

🚀 Feature

We are in the process of adding native plotting to torchmetrics such that our users can easily create simple plots of metrics, which is especially useful for metrics such as confusion matrix and pr-curves but even single-scalar metrics such as accuracy it can be beneficial to quickly create a plot of computed values.

The first proof of concept PR has just been merged: #1328

We are inviting anyone interested in contributing to torchmetrics to help add this feature to all remaining metrics. The tasks are fairly simple and an example of how to implement the plot metric can be seen here: https://github.com/Lightning-AI/metrics/blob/d8caeeb28efc0afb86ae68cf66b06412749a4e46/src/torchmetrics/classification/accuracy.py#L110-L156

We would like the work divided into PRs tackling each domain, however if any are interested in only contributing to a few metrics within a particular domain that is also more than welcome.

@SkafteNicki SkafteNicki added enhancement New feature or request help wanted Extra attention is needed labels Dec 23, 2022
@SkafteNicki SkafteNicki added this to the v0.12 milestone Dec 23, 2022
@Borda Borda added the good first issue Good for newcomers label Dec 23, 2022
@ufukhurriyetoglu
Copy link

I would be happy to work on this issue

@srishti-git1110
Copy link
Contributor

Interested in working on the Regression and Classification subcategory.

@Borda
Copy link
Member

Borda commented Dec 23, 2022

I would be happy to work on this issue

@ufukhurriyetoglu cool, which category you would like to take?

Interested in working on the Regression and Classification subcategory.

@srishti-git1110 great, noting it 🐰

@venomouscyanide
Copy link
Contributor

I would love to work on any subtask as well.

@shhs29
Copy link
Contributor

shhs29 commented Dec 23, 2022

I am also interested in contributing to any of the subtasks.

@ufukhurriyetoglu
Copy link

ufukhurriyetoglu commented Dec 23, 2022

@Borda text and retrieval, and maybe audio if needed at the time we finish the first two.

@Borda
Copy link
Member

Borda commented Dec 24, 2022

I am also interested in contributing to any of the subtasks.

@shhs29 cool, so how about audio?

@shhs29
Copy link
Contributor

shhs29 commented Dec 24, 2022

I am also interested in contributing to any of the subtasks.

@shhs29 cool, so how about audio?

@Borda That sounds good.

@venomouscyanide
Copy link
Contributor

venomouscyanide commented Dec 24, 2022

I would love to work on any subtask as well.

I was wondering if there was anything left for me to pickup as well?

@Borda
Copy link
Member

Borda commented Dec 24, 2022

I would love to work on any subtask as well.

I was wondering if there was anything left for me to pickup as well?

sure, there are still Image, Detection and Aggregation 🎁

@venomouscyanide
Copy link
Contributor

I would love to work on any subtask as well.

I was wondering if there was anything left for me to pickup as well?

sure, there are still Image, Detection and Aggregation 🎁

I guess I'll go with Image.

@Borda
Copy link
Member

Borda commented Jan 5, 2023

hi, everyone how was your Xmass break? did you have a chance to look at your tasks? 🦦
cc: @shhs29, @srishti-git1110, @venomouscyanide, @ufukhurriyetoglu

@venomouscyanide
Copy link
Contributor

@Borda Sorry for the lack of communication on this. I will have a draft PR ready latest by Sunday.

@shhs29
Copy link
Contributor

shhs29 commented Jan 5, 2023

@Borda I am also planning to raise a draft PR by this weekend. Sorry for the delay.

@srishti-git1110
Copy link
Contributor

@Borda Hey, yes! Have been looking into it. This is also my first time contributing to an open source project so a bit overwhelmed at the moment, but I'm on it 💪. Please expect an update within a week from now.

@rschireman
Copy link

Hi @Borda, I can work on plotting Detection metrics, do you have any preferences on what should be included?

@ufukhurriyetoglu
Copy link

hi @Borda targeting a draft PR for text this weekend. And will also kickstart information retrieval in parallel.

@ufukhurriyetoglu
Copy link

hi @Borda targeting a draft PR for text this weekend. And will also kickstart information retrieval in parallel.

I kickstarted the text branch work locally, will be working on this and information retrieval daily and keep you posted.

@shhs29
Copy link
Contributor

shhs29 commented Jan 9, 2023

@Borda @SkafteNicki I have created a draft PR for adding plot to pesq metric. The link to the PR is: #1434. I am looking for some feedback before I move to the next set of metrics. I would appreciate it if you can point me to the contact person for this.

@venomouscyanide
Copy link
Contributor

Just a quick update. I have started working on this locally for image. I will try to have a draft PR open soon. I am also getting help as reference from @shhs29 's #1434 to help me kick-start things.

@Borda
Copy link
Member

Borda commented Feb 2, 2023

Hi @shhs29, @srishti-git1110, @venomouscyanide, @ufukhurriyetoglu, how is it going? we would like to get this to the upcoming 0.12 release...
btw, if you need some assistance, just create a draft PR and ping us 🦦
in case you won't have time to make it, it is completely fine, just let us know, and we offer it to someone else from the community 🐿️

@shhs29
Copy link
Contributor

shhs29 commented Feb 2, 2023

Hi @shhs29, @srishti-git1110, @venomouscyanide, @ufukhurriyetoglu, how is it going? we would like to get this to the upcoming 0.12 release... btw, if you need some assistance, just create a draft PR and ping us 🦦 in case you won't have time to make it, it is completely fine, just let us know, and we offer it to someone else from the community 🐿️

Hi @Borda,
I have finished adding plot to one of the audio metrics. The CI workflow is however failing and I would like some feedback. The link to the PR is: #1434. I have pinged you regarding the issue on Slack as well. I would appreciate it if you could provide feedback on my current approach.

@venomouscyanide
Copy link
Contributor

@Borda I will definitely have a draft PR open by the weekend. If not, I will resign from this activity to avoid further delays for your team 😄

@alexkrz
Copy link
Contributor

alexkrz commented Feb 6, 2023

Hi @Borda @SkafteNicki @srishti-git1110: I feel like the classification category is a rather large task. Maybe we can divide it into subcategories? I would be happy to draft a PR for plot support for AUROC and ROC metrics.

@srishti-git1110
Copy link
Contributor

Hi @alexkrz. Great! I'm working on other classification and regression metrics - you can take up AUROC and ROC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
8 participants