Move prepare_* scripts inside the package
#1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
approved these changes
Mar 7, 2024
| from litgpt import Tokenizer | ||
| from litgpt.utils import CLI | ||
| from litgpt.data.prepare_starcoder import DataChunkRecipe |
There was a problem hiding this comment.
I don't get this part.
Since we are using the latest lightning commit and the [data] extra, this should already use lit_data.
But ok, I can look at this again in #1034
There was a problem hiding this comment.
This is for the base installation (not requirements-all) which doesn't include data
awaelchli
pushed a commit
that referenced
this pull request
Mar 15, 2024
awaelchli
pushed a commit
that referenced
this pull request
Mar 15, 2024
awaelchli
pushed a commit
that referenced
this pull request
Mar 15, 2024
rasbt
pushed a commit
that referenced
this pull request
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #548, #996