-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add utility function to benchmark performance of fusion region with nvfuser and torch.compile #1682
Add utility function to benchmark performance of fusion region with nvfuser and torch.compile #1682
Conversation
…vfuser and torch.compile
cc: @kiya00 I think this could be useful for automated report generation, would be great to have your review on this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks useful though I have some questions that might be orthogonal to this PR itself
This looks ready to take out of draft to me, @kshitij12345, but maybe you have some more ideas Running this and translating the slower fusions into bugs was incredibly interesting and helpful fyi @kiya00, @riccardofelluga, I expect we'll want to develop the ability to have torch.compile or thunderfx run different fxgraphs, and maybe also the ability to autobenchmark torch.compile vs nvfuser on each fusion to select the faster of the two. We can talk about this more as we develop the new reporting tools |
I just wanted to update the description with an example usage, which is done. Have marked PR as ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adds a utility function to benchmark the performance of nvFuser and torch.compile for a given fusion region.
Example Usage -
Output