Add a new dynamo.last_traces entry point. #1614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-vi
reviewed
Jan 7, 2025
tfogal
force-pushed
the
tfogal/tfx-last-traces
branch
3 times, most recently
from
030a991 to
fcedf0c
Compare
kshitij12345
reviewed
Jan 9, 2025
tfogal
force-pushed
the
tfogal/tfx-last-traces
branch
from
444e30f to
4182e96
Compare
|
@IvanYashchuk do you want to take a look before merging? |
kshitij12345
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Overall LGTM, just a couple of comments and should clean-up the changes pointed by @IvanYashchuk
Thank you @tfogal
To make it simple to grab the important traces.
And return a list of Traces instead of flattening it into a string.
for more information, see https://pre-commit.ci
tfogal
force-pushed
the
tfogal/tfx-last-traces
branch
from
4182e96 to
809490e
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
t-vi
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Stamping based on @kshitij12345 's review. Thank you @tfogal @kshitij12345
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am constantly rewriting this so I thought upstreaming something made sense.
Not married to the implementation, but @t-vi @IvanYashchuk curious for your thoughts on having an explicitly entry point for this?
What does this PR do?
It adds a new entry point which iterates over all the ThunderFX subgraphs and grabs the trace information.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.