-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swift 6 and concurrency update #18
Conversation
Signed-off-by: Michael Amundsen <[email protected]>
Signed-off-by: Michael Amundsen <[email protected]>
Signed-off-by: Michael Amundsen <[email protected]>
Signed-off-by: Michael Amundsen <[email protected]>
Signed-off-by: Michael Amundsen <[email protected]>
Signed-off-by: Michael Amundsen <[email protected]>
Signed-off-by: Michael Amundsen <[email protected]>
public extension RequestBehavior { | ||
func requestWillSend(request: inout URLRequest) { } | ||
func requestDidFinish(result: Result<NetworkResponse, NetworkError>) { } | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These seem to be the get called even when you conform the type which causes unexpected behavior. Removing them so you have to determine what you want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure we mark the next version as a new major version then, as this is a breaking change.
What it Does
Sendable
How I Tested
Notes
@MainActor
to enforce it being called from the thread and then always receiving on that thread. I can't scope it to something like the MainQueueScheduler we have in ViewStore, so I updated the docs to call it out.