Issue619: add support for rowspan #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the new Feature/Bugfix
Describe here how you fixed the bug, or implemented the new feature.
Digging into the endElement method of HTMLworker class, I find there is something wrong with IncCell, which only adds the support for colspan of tr. In this way, I add one line of code in constructor of IncCell to imitate the setting of colspan to enable rowspan.
Related Issue: #619
Expected Result:
Wrong Result:
Unit-Tests for the new Feature/Bugfix
Compatibilities Issues
Is anything broken because of the new code? Any changes in method signatures?
No, there is nothing broken because of the new code. No, there is no change in method signatures
Testing details
Any other details about how to test the new feature or bugfix?
I reproduce the broken steps of nonsupport of rowspan.