Slight refactoring of cross-reference table entries #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -51,6 +51,11 @@ | |||
| <version>${jupiter.version}</version> | |||
| <scope>test</scope> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>org.mockito</groupId> | |||
There was a problem hiding this comment.
Why add another dependency? Perhaps test scope only?
There was a problem hiding this comment.
Yes, forgot it while making changes
|
Why are you refactoring the cross-reference table entries ? |
|
Does this change break the API for existing users of OpenPDF? |
To clarify and document existing behaviour as well as add tests for it |
No, it should not |
|
Thanks. Please help with #128. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, added license header in test file. If it has appropriate format, I will add it to the files where I missed to add it