Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eventlircd: fix subsystem rules for bluetooth HID remotes #9587

Merged
merged 1 commit into from
Jan 12, 2025

Conversation

Dashinginthe90s
Copy link
Contributor

Fix for issue 9586

Removes check for SUBSYSTEMS=="bluetooth" since it is not used for bluetooth HID remotes. They use the input subsystem instead.

@chewitt
Copy link
Member

chewitt commented Dec 17, 2024

@Dashinginthe90s please update the commit message (not the PR subject) to follow package: description of change house-style, e.g.eventlircd: fix subsystem rules for bluetooth HID remotes

@HiassofT HiassofT removed their request for review December 17, 2024 17:00
@HiassofT
Copy link
Member

I'm not familiar with bluetooth stuff so I'll let someone else review this.

Also as there is currently ongoing development to add support for keys with scancode > 255 to kodi there's some chance we can retire eventlircd soon.

@Dashinginthe90s Dashinginthe90s changed the title Fix subsystem check for bluetooth HID remotes in eventlircd udev rules eventlircd: fix subsystem rules for bluetooth HID remotes Dec 18, 2024
@Dashinginthe90s Dashinginthe90s force-pushed the eventlircd-udev-rules-fix branch from 0cd81d3 to 235d214 Compare December 18, 2024 01:29
@DUTNO1
Copy link

DUTNO1 commented Dec 31, 2024

Tested this on 12.0.1 and it restores functionality of the PS3 remote to pre-LE12 behaviour, thanks @Dashinginthe90s !

Copy link
Member

@chewitt chewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chewitt chewitt merged commit aab3b5b into LibreELEC:master Jan 12, 2025
@chewitt
Copy link
Member

chewitt commented Jan 12, 2025

@Dashinginthe90s can we have a backport PR for LE12 branch too?

@Dashinginthe90s
Copy link
Contributor Author

can we have a backport PR for LE12 branch too?

@chewitt I've Submitted #9671

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants