lirc: fix lock directory / rework VERSION_NODOTS computation #9521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Left over lib/lirc/config.h lead to "LIRC_LOCKDIR" redefined to not existing
"/var/lock/lockdir" (beside others):
/home/docker/LibreELEC.tv/build.LibreELEC-gbm.x86_64-12.0-devel-mg/build/lirc-0.10.2/lib/lirc/config.h:198: warning: "LIRC_LOCKDIR" redefined
198 | #define LIRC_LOCKDIR "/var/lock/lockdev"
|
In file included from /home/docker/LibreELEC.tv/build.LibreELEC-gbm.x86_64-12.0-devel-mg/build/lirc-0.10.2/lib/driver.c:12:
./config.h:198: note: this is the location of the previous definition
198 | #define LIRC_LOCKDIR "/var/lock"
|
Furthermore define lock dir because lirc's configure does check the host system and use
/var/lock/lockdev if existing.
CvH
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #9520
This forum post reports use of not existent /var/lock/lockdev directory of lirc.
configure does detect /var/lock correctly but there is a left over lib/lirc/config.h in lirc release archive 0.10.2 overwriting the path. Delete the file.
Furthermore define lock directory using
--with-lockdir=/var/lockbecause lirc's configure does check the host file system and set /var/lock/lockdev if existing.I difference to master branch the missing VERSION_NODOTS value only generate a warning in get_server_version() even being a bug. Change the disable python patch to use shell script instead of python code to compute the value.