Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flickering with graphic overlays for Rockchip/Allwinner #9269

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

NetDwarf
Copy link
Contributor

@NetDwarf NetDwarf commented Sep 7, 2024

Fix suggested by @knaerzche

@NetDwarf
Copy link
Contributor Author

NetDwarf commented Sep 7, 2024

Fix was tested on Rock64 as described here: #9065 (comment)

@knaerzche
Copy link
Contributor

knaerzche commented Sep 8, 2024

@jernejsk did you test with AW?
The issue isn't really visable when navigating in the gui, but it's very visable when using subtitles, or just using the info overlay during video playback. I'd say until a fix is found, it's better to revert xbmc/xbmc#23921 (like RPi does)

@NetDwarf
Copy link
Contributor Author

NetDwarf commented Sep 9, 2024

Okay, compiled and tested the code from this branch on the QPlus (Allwinner H6/Tanix-like) and it works. There is no flicker on overlay as was present on 12.0.0 when opening menus/infos etc.

@CvH
Copy link
Member

CvH commented Sep 19, 2024

@knaerzche gtg ?

@knaerzche knaerzche merged commit 7e8052c into LibreELEC:master Sep 19, 2024
@jernejsk
Copy link
Member

jernejsk commented Sep 19, 2024

@jernejsk did you test with AW?

Sorry, not yet. I'm good with reverting it until better solution is found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants