Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meson: use chosen linker #8481

Merged
merged 1 commit into from
Mar 7, 2025
Merged

meson: use chosen linker #8481

merged 1 commit into from
Mar 7, 2025

Conversation

dhewg
Copy link
Contributor

@dhewg dhewg commented Jan 5, 2024

meson requires setting the linker via c_ld/cpp_ld.
This now links meson based package builds with the chosen DEFAULT_LINKER.

@dhewg
meson: use chosen linker
52858e7 
meson requires setting the linker via c_ld/cpp_ld.
This now links meson based package builds with the chosen
DEFAULT_LINKER.

Signed-off-by: Andre Heider <[email protected]>
@dhewg dhewg mentioned this pull request Jan 5, 2024
Merged
@heitbaum heitbaum added MERGE BLOCKED BUILDSYSTEM NEEDS REVIEW Issue needs review from a team member. LE 13.0 labels Jan 5, 2024
@heitbaum
Copy link
Contributor

heitbaum commented Jan 5, 2024

For review and testing with LE13. This changes the meson ld from bfd to gold/mold.

Member
@heitbaum heitbaum 13 hours ago
This makes sense. Does this mean that we have been usingbfd for all meson:target builds? What is the impact of these builds now using gold or mold? (Well specifically gold as it is the default in the LE12 image?)
Member
Author
@dhewg dhewg 12 hours ago
Yes, I believe those have been using bfd all along.
I only tested mold for my allwinner board though. While that works just fine, I neither tested gold nor any other platform
Member
@heitbaum heitbaum 11 hours ago
This one will need more testing then. I just noticed pixman on the 0.43.0 update is meson and it explicitly wanted bfd in configure, but with this change gold would be used. So let’s hold this commit back for LE12.

@chewitt chewitt requested a review from heitbaum February 24, 2025 12:37
@heitbaum
Copy link
Contributor

I have run this through a few iterations now on Generic (successfully.) Going to run the test builds on the other targets and addon-arm,addon-aarch64,addon-Generic-legacy.

@heitbaum
Copy link
Contributor

heitbaum commented Mar 1, 2025

I’ve run through all the target builds. No issues. So just the addon run. Whilst we are here though? What are we doing with gold - not an immediate issue, but with upstream only updating gold every second cycle based on the release notes…

@heitbaum
Copy link
Contributor

heitbaum commented Mar 2, 2025

I’ve tested all of Generic-legacy, Generic, ARMV7 and ARMv8 addon builds. Looks like this PR doesn’t have issues in these. Removing merge-block and needs-review

@heitbaum heitbaum removed MERGE BLOCKED NEEDS REVIEW Issue needs review from a team member. labels Mar 2, 2025
@heitbaum heitbaum merged commit 5ca746b into LibreELEC:master Mar 7, 2025
@dhewg dhewg deleted the mold branch March 7, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heitbaum heitbaum heitbaum approved these changes

Assignees
No one assigned
Labels
BUILDSYSTEM LE 13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhewg @heitbaum