Update retroplayer add-ons

[garbear]

Description

In my latest round of game add-on updates, I used the package definitions curated by the Lakka team to fix a bunch of problems and update a bunch of metadata across all the game add-ons in the kodi-game org.

I also used the Lakka packages to update the retroplayer add-ons in this repo. As a result, all retroplayer add-ons build again.

All commit hashes in both this repo and across the kodi-game org have been updated, so versions of all retroplayer add-ons are now in sync across the entire LibreELEC and Kodi ecosystem.

We're currently discussing which cores we want to support in slack. I mostly updated existing cores in this PR, but a few cores were added for platform coverage and a few were removed due to platform redundancy.

How has this been tested?

I've test-compiled everything except for uae4arm for:

• Generic
• PRi2
• PRi4
• RK3399

[CvH]

pushed some fixups

[garbear]

kodi-platform shouldn't be used in packages/emulation. Theoretically, once this is merged, Lakka can actually use our recipes as an upstream:

kodi-game@ac87165

I doubt they will, but we can dream.

[HiassofT]

@CvH I won't have time to look at this the next weeks, as long as the addons build for ARMv7, ARMv8, Generic and Generic-legacy I'm fine with any solution you've come up with

[garbear]

@CvH I did one last round of game add-on updates using kodi-game-scripting, then ran update_retroplayer-addons.

Now every single game add-on is in sync across the whole Kodi + LibreELEC ecosystem.

As part of the effort, I've fully updated https://kodi.wiki/view/Game_add-ons for all game add-ons, which sources everything from upstream.

Small request, Can you update the licenses according to the wiki page? The goal is license-correctness with upstream as a source of truth. If you don't have time, then we'll remove the fix licences commit and merge and update all licenses later.

If you choose to update the licenses, I'll take care of upstreaming it so that we don't have to do this again.

[CvH]

The licences were changed to align it with upstream at libretro. I have a look what is actually different.

[CvH]

Can you update the licenses according to the wiki page?

I reviewed and the commit is correct and the licences are gathered from their sources.
You may need to fix the kodi wiki to stay inline with upstream.

wrong stuff at the kodi wiki

Elektronika - BK - NTP

bsnes - GPLv3 + ISC (bsnes itself is GPLv3 at the package included and used libs are ISC - is arguable)

cannonball - somewhere was stated mame as licence, can't find it right now but at the source there is several times
"Based on MAME source code" - "non commercial" is not a proper licence and its very unlikely that they asked all mame contributions to relicense for cannonball :D

dinothawr - CC-BY-NC-SA-3.0

o2em - Artistic-2.0 instead of the old Artistic

quicknes - GPLv2

the changes at the game.libretro.xxx stuff is taken from upstream, so either upstream is wrong or we :)

I push the fix for bsnes.

[garbear]

I should have mentioned, "upstream" is the info files here: https://github.com/libretro/libretro-super/tree/master/dist/info

The license in these files is used to generate the license on the game.libretro.xxx repos. So libretro-super is the source of truth we're using.

That said, now that you've done the work, I'll take care of upstreaming to libretro-super and lakka. Thanks!

[CvH]

I splitted the commits a bit for easier diffs.

[KOPRajs]

FYI: While playing with the experimental GLES shader support in LE I've found out that the PCSX emulator is broken in the current LE 11.0.1 for Generic x86_64 (it works only for ARMv8). On x86_64 it is causing Kodi to segfault upon start of any game. I've tried to build the PCSX from master after this PR got merged and now it works on the Generic build again.

Maybe this should be backported to LE 11?