fix BrnProgressChart 设置颜色，背景色，以及动画无效 #322
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
violinday
reviewed
Sep 8, 2022
| final Duration duration; | ||
|
|
||
| /// 进度条是否从上次的值开始 | ||
| final bool isReverse; |
There was a problem hiding this comment.
isReverse 字面意思和注释说明的作用不同。
是想表达进度条动画从最近一次的值开始不. : )
There was a problem hiding this comment.
isAnimationStartFromLastValue 这样命名呢😂
| @override | ||
| Widget build(BuildContext context) { | ||
| final double _value = widget.value; |
|
|
||
| @override | ||
| void paint(Canvas canvas, Size size) { | ||
| final double value = animation?.value ?? this.value; |
There was a problem hiding this comment.
局部变量 value 作用域覆盖了 类的字段 value。
可能会对 45、46 行的 value 判断有影响
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.