fix: warning in flutter3.0 (#232)

* fix: warning in flutter3.0 * Apply suggestions from code review Co-authored-by: Alex Li <[email protected]> Co-authored-by: Alex Li <[email protected]>
LianjiaTech · Jun 3, 2022 · 45e51df · 45e51df
1 parent 97887e4
commit 45e51df
Show file tree

Hide file tree

Showing 8 changed files with 20 additions and 12 deletions.
diff --git a/lib/src/components/appraise/brn_flutter_gif_image.dart b/lib/src/components/appraise/brn_flutter_gif_image.dart
@@ -1,6 +1,7 @@
 import 'dart:ui' as ui show Codec;
 import 'dart:ui';
 
+import 'package:bindings_compatible/bindings_compatible.dart';
 import 'package:flutter/widgets.dart';
 
 /// 描述: 用于加载gif图，
@@ -127,7 +128,7 @@ class GifImageState extends State<GifImage> {
       dynamic data;
       AssetBundleImageKey key = await provider.obtainKey(ImageConfiguration());
       data = await key.bundle.load(key.name);
-      ui.Codec codec = await PaintingBinding.instance!
+      ui.Codec codec = await usePaintingBinding()
           .instantiateImageCodec(data.buffer.asUint8List());
       for (int i = 0; i < codec.frameCount; i++) {
         FrameInfo frameInfo = await codec.getNextFrame();

diff --git a/lib/src/components/navbar/brn_appbar.dart b/lib/src/components/navbar/brn_appbar.dart
@@ -1,5 +1,6 @@
 import 'dart:ui';
 
+import 'package:bindings_compatible/bindings_compatible.dart';
 import 'package:bruno/src/components/line/brn_line.dart';
 import 'package:bruno/src/theme/brn_theme_configurator.dart';
 import 'package:bruno/src/theme/configs/brn_appbar_config.dart';
@@ -240,7 +241,7 @@ class BrnAppBar extends PreferredSize {
         .appBarConfig
         .merge(_defaultConfig);
 
-    WidgetsBinding.instance?.addPostFrameCallback((_) {
+    useWidgetsBinding().addPostFrameCallback((_) {
       SystemChrome.setSystemUIOverlayStyle(_defaultConfig.systemUiOverlayStyle);
     });
     return super.build(context);

diff --git a/lib/src/components/navbar/brn_search_bar.dart b/lib/src/components/navbar/brn_search_bar.dart
@@ -1,4 +1,5 @@
 import 'package:bruno/src/components/navbar/brn_appbar.dart';
+import 'package:bindings_compatible/bindings_compatible.dart';
 import 'package:bruno/src/components/navbar/brn_appbar_theme.dart';
 import 'package:bruno/src/constants/brn_asset_constants.dart';
 import 'package:bruno/src/constants/brn_strings_constants.dart';
@@ -106,7 +107,7 @@ class BrnSearchAppbar extends PreferredSize {
   Size get preferredSize => Size.fromHeight(BrnAppBarTheme.appBarHeight);
 
   Widget build(BuildContext context) {
-    WidgetsBinding.instance?.addPostFrameCallback((_) {
+    useWidgetsBinding().addPostFrameCallback((_) {
       SystemChrome.setSystemUIOverlayStyle(SystemUiOverlayStyle.light);
     });
     return super.build(context);

diff --git a/lib/src/components/noticebar/brn_marquee_text.dart b/lib/src/components/noticebar/brn_marquee_text.dart
@@ -1,4 +1,6 @@
 import 'dart:async';
+
+import 'package:bindings_compatible/bindings_compatible.dart';
 import 'package:flutter/material.dart';
 
 /// 文字跑马灯Widget
@@ -54,7 +56,7 @@ class BrnMarqueeTextState extends State<BrnMarqueeText>
   void initState() {
     super.initState();
     scroController = new ScrollController();
-    WidgetsBinding.instance?.addPostFrameCallback((callback) {
+    useWidgetsBinding().addPostFrameCallback((callback) {
       var size = context.findRenderObject()!.paintBounds.size;
       widget.width = (widget.width) > 0 ? widget.width : size.width;
       widget.height = (widget.height) > 0 ? widget.height : size.height;

diff --git a/lib/src/components/popup/brn_measure_size.dart b/lib/src/components/popup/brn_measure_size.dart
@@ -1,3 +1,4 @@
+import 'package:bindings_compatible/bindings_compatible.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter/rendering.dart';
 
@@ -21,11 +22,10 @@ class MeasureSizeRenderObject extends RenderProxyBox {
     if (oldSize == newSize) return;
 
     oldSize = newSize;
-    if (WidgetsBinding.instance != null) {
-      WidgetsBinding.instance!.addPostFrameCallback((_) {
-        onChange(newSize);
-      });
-    }
+
+    useWidgetsBinding().addPostFrameCallback((_) {
+      onChange(newSize);
+    });
   }
 }
 

diff --git a/lib/src/components/scroll_anchor/brn_scroll_anchor_tab.dart b/lib/src/components/scroll_anchor/brn_scroll_anchor_tab.dart
@@ -1,3 +1,4 @@
+import 'package:bindings_compatible/bindings_compatible.dart';
 import 'package:bruno/src/components/popup/brn_measure_size.dart';
 import 'package:bruno/src/components/tabbar/normal/brn_tab_bar.dart';
 import 'package:flutter/gestures.dart';
@@ -69,7 +70,7 @@ class _BrnScrollAnchorTabWidgetState extends State<BrnAnchorTab>
 
     fillKeyList();
 
-    WidgetsBinding.instance?.addPostFrameCallback((da) {
+    useWidgetsBinding().addPostFrameCallback((da) {
       fillOffset();
       _scrollController.addListener(() {
         _updateOffset();
@@ -97,7 +98,7 @@ class _BrnScrollAnchorTabWidgetState extends State<BrnAnchorTab>
     if (sub != 0) {
       _tabController = TabController(length: widget.itemCount, vsync: this);
     }
-    WidgetsBinding.instance?.addPostFrameCallback((da) {
+    useWidgetsBinding().addPostFrameCallback((da) {
       fillOffset();
     });
   }

diff --git a/lib/src/components/selection/widget/brn_layer_more_selection_page.dart b/lib/src/components/selection/widget/brn_layer_more_selection_page.dart
@@ -1,3 +1,4 @@
+import 'package:bindings_compatible/bindings_compatible.dart';
 import 'package:bruno/src/components/line/brn_line.dart';
 import 'package:bruno/src/components/selection/bean/brn_selection_common_entity.dart';
 import 'package:bruno/src/components/selection/brn_more_selection.dart';
@@ -46,7 +47,7 @@ class _BrnLayerMoreSelectionPageState extends State<BrnLayerMoreSelectionPage>
   @override
   void initState() {
     super.initState();
-    WidgetsBinding.instance?.addPostFrameCallback((_) {
+    useWidgetsBinding().addPostFrameCallback((_) {
       SystemChrome.setSystemUIOverlayStyle(SystemUiOverlayStyle.dark);
     });
     _controller = AnimationController(

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -17,6 +17,7 @@ dependencies:
   photo_view: ^0.13.0
   provider: ^6.0.1
   badges: ^2.0.2
+  bindings_compatible: ^1.0.1
 
 dev_dependencies:
   flutter_test: