Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also search url field by default #5459

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Also search url field by default #5459

merged 1 commit into from
Feb 28, 2025

Conversation

Nutomic
Copy link
Member

@Nutomic Nutomic commented Feb 27, 2025 •
edited
Loading

dessalines
dessalines approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably fine, but be aware that this will only match exact urls, its not doing a fuzzy search like the other fields.

@Nutomic
Copy link
Member Author

Nutomic commented Feb 28, 2025

Yes it matches the existing url_only search.

@dessalines dessalines merged commit 6e3355f into main Feb 28, 2025
2 checks passed
@SleeplessOne1917 SleeplessOne1917 deleted the search-url branch February 28, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dessalines dessalines dessalines approved these changes

@SleeplessOne1917 SleeplessOne1917 SleeplessOne1917 approved these changes

@phiresky phiresky Awaiting requested review from phiresky phiresky is a code owner

@dullbananas dullbananas Awaiting requested review from dullbananas dullbananas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nutomic @dessalines @SleeplessOne1917