Simplify slur regex #5442
Simplify slur regex #5442
Conversation
Nutomic
requested review from
dessalines,
phiresky,
dullbananas and
SleeplessOne1917
as code owners
There was a problem hiding this comment.
Since regex changes pretty infrequently, regex checking should probably make use of caching anyway, instead of reading the site from the DB every time, via https://github.com/LemmyNet/lemmy/blob/main/crates/api_crud/src/site/read.rs#L26
| @@ -1037,7 +1031,7 @@ pub fn check_conflicting_like_filters( | |||
|
|
|||
| pub async fn process_markdown( | |||
| text: &str, | |||
| slur_regex: &Option<LemmyResult<Regex>>, | |||
| slur_regex: &Regex, | |||
There was a problem hiding this comment.
Now that this is no longer an option, isn't it going to throw the new lemmyerror you created? Or maybe since it matches nothing it should be ok.
I feel like Option<Regex (which is the reality in the DB) is probably better and more explicit than a missing regex that default matches nothing, but its up to you I spose.
There was a problem hiding this comment.
The error would only be thrown if the regex is invalid, and that shouldnt happen as its checked before create/update.
Option<Regex> also works, but this way the code is a bit simpler.
No description provided.