Specify password length limits in error (fixes #3284) #4007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phiresky
reviewed
Oct 4, 2023
crates/utils/src/error.rs
Outdated
| @@ -106,6 +106,7 @@ pub enum LemmyErrorType { | |||
| PersonIsBlocked, | |||
| DownvotesAreDisabled, | |||
| InstanceIsPrivate, | |||
| #[serde(rename = "Password must be between 10 and 60 characters")] | |||
There was a problem hiding this comment.
it doesn't feel like serde rename is the right thing to do here and this seems to make the code worse to me. The error enum should be something you can match by in the client exactly e.g. if e.error === "InvalidPassword" { show(e.message) } and not something that will change over time or be printable directly.
So it seems to me like maybe this should rather be InvalidPassword(String) or InvalidPassword(&'static str) or there should be a separate (client-side) mapping from LemmyErrorType to a printable (and translatable) string.
There was a problem hiding this comment.
Okay I converted this to a comment instead. Also moving the issue to lemmy-ui.
dessalines
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.