Optimize Tagline Form page #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makotech222
force-pushed
the
taglines-optimize
branch
from
1091e10 to
e21cee6
Compare
dessalines
reviewed
Mar 30, 2023
| siteRes: GetSiteResponse; | ||
| siteForm: EditSite; | ||
| loading: boolean; | ||
| editingRow: number | null; |
There was a problem hiding this comment.
Use undefined:
editingRow?: number
| <table id="taglines_table" className="table table-sm table-hover"> | ||
| <thead className="pointer"> | ||
| <th></th> | ||
| <th style="width:121px"></th> |
There was a problem hiding this comment.
Don't hard code widths like this. Use responsive bootstrap tables.
There was a problem hiding this comment.
This is pulled from emoji table, used for same reason, just to give a min width to the column to have two buttons on the same row.
There was a problem hiding this comment.
Okay, but I highly suggest you read over how bootstrap does responsive forms: https://getbootstrap.com/docs/5.0/forms/overview
dessalines
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work moves the tagline editing from the main Site Settings form into its own tab, like emojis. It also is optimized for larger lists, allowing hundreds of taglines without slowing down the page.
I wrote this up pretty quick, didn't want to refactor too much, just needed to get past a blocker for hexbear. Its still worthy of upstreaming it, though, as current implementation falls apart if you have lots of taglines.